[GitHub] [doris] morningman commented on a diff in pull request #19541: [feature](catalog)add new check for catalog property

["morningman (via GitHub)" <gi...@apache.org>]

morningman commented on code in PR #19541:
URL: https://github.com/apache/doris/pull/19541#discussion_r1190889343


##########
fe/fe-core/src/main/java/org/apache/doris/common/util/PropertyAnalyzer.java:
##########
@@ -794,6 +796,14 @@ public static boolean analyzeUniqueKeyMergeOnWrite(Map<String, String> propertie
      */
     public static void checkCatalogProperties(Map<String, String> properties, boolean isAlter)
             throws AnalysisException {
+        // firstly, check if the property's key contains empty character
+        for (Map.Entry<String, String> entry : properties.entrySet()) {

Review Comment:
   Not a good solution.
   It cannot handle all situation, like containing other charactors.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org