You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ishu7w (via GitHub)" <gi...@apache.org> on 2026/10/06 16:30:17 UTC
[PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
ishu7w opened a new pull request, #23731:
URL: https://github.com/apache/kafka/pull/23731
Two method-chain continuation lines in `ListConsumerGroupOffsetsHandler.coordinatorKeys()` use 11 leading spaces. Align them at 12 spaces, consistent with Kafka's default `Indentation` configuration.
These existing formatting errors are detected by the wrapped-return-expression fix in checkstyle/checkstyle#21833 and cause its Kafka compatibility job to fail. This change only adds one space to each line.
Validation: ran Kafka's full Checkstyle configuration against this file using the Checkstyle build from that PR. The original file reports the two violations at lines 85 and 86; the corrected file passes with zero violations. No behavior changes or new tests.
Prepared with assistance from OpenAI Codex. This contribution is original work and is licensed under the project's Apache License 2.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-6486911944
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "squah-confluent (via GitHub) via jira" <ji...@kafka.apache.org>.
squah-confluent commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-7030470249
@ishu7w Thanks for the fix! Could you update the PR description? It will become the commit message verbatim and most of it doesn't belong in git history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "ishu7w (via GitHub) via jira" <ji...@kafka.apache.org>.
ishu7w commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-7037173377
Thanks, Sean! I’ve shortened the description to just the indentation change and kept the reviewer line. The diff is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "ishu7w (via GitHub)" <gi...@apache.org>.
ishu7w commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-6319746450
Gentle follow-up: this formatting correction is still needed by Checkstyle PR #21833’s `no-error-kafka` check. The PR has its label checks passing and is waiting for review. Once this is reviewed and merged, Checkstyle can rerun the downstream check. Please let me know if you would like any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "github-actions[bot] (via GitHub) via jira" <ji...@kafka.apache.org>.
github-actions[bot] commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-7029261144
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "ishu7w (via GitHub)" <gi...@apache.org>.
ishu7w commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-6407719154
The fresh `no-error-kafka` run on Checkstyle PR #21833 (Oct 25) still reports only the two indentation violations in `ListConsumerGroupOffsetsHandler.java` at lines 85–86 (actual level 11, expected 12). This PR changes those exact lines to the expected indentation. Could a maintainer review it when convenient? It is the remaining dependency for #21833’s check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "ishu7w (via GitHub) via jira" <ji...@kafka.apache.org>.
ishu7w commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-6947958781
Could a Kafka committer take a look when they have time? This two-line formatting change is still the blocker for Checkstyle’s Kafka audit on checkstyle/checkstyle#21833.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23731:
URL: https://github.com/apache/kafka/pull/23731#issuecomment-6183643580
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Fix consumer group offset handler chain indentation [kafka]
Posted by "squah-confluent (via GitHub) via jira" <ji...@kafka.apache.org>.
squah-confluent merged PR #23731:
URL: https://github.com/apache/kafka/pull/23731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org