You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/21 16:38:35 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #10560: ARROW-13127: [R] Valgrind nightly errors

nealrichardson commented on a change in pull request #10560:
URL: https://github.com/apache/arrow/pull/10560#discussion_r655541933



##########
File path: r/tests/testthat/test-RecordBatch.R
##########
@@ -571,7 +571,7 @@ test_that("RecordBatchReader to C-interface", {
 
   # export the RecordBatchReader via the C-interface
   stream_ptr <- allocate_arrow_array_stream()
-  on.exit(delete_arrow_array_stream(stream_ptr))
+  on.exit(delete_arrow_array_stream(stream_ptr), add = TRUE)

Review comment:
       FWIW the `add = TRUE` argument does not exist in all versions of R that we support today (I can't remember whether it was added in 3.4 or 3.5). 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org