You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <an...@apache.org> on 2017/01/25 19:49:18 UTC
Review Request 55942: Added a test for validating streaming
request/response headers.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55942/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-6936
https://issues.apache.org/jira/browse/MESOS-6936
Repository: mesos
Description
-------
Added a test for validating streaming request/response headers.
Diffs
-----
src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
Diff: https://reviews.apache.org/r/55942/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 55942: Added a test for validating streaming
request/response headers.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55942/#review163066
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/api_tests.cpp (line 4694)
<https://reviews.apache.org/r/55942/#comment234501>
s/response/request/
- Vinod Kone
On Jan. 25, 2017, 7:49 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55942/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 7:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for validating streaming request/response headers.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
>
> Diff: https://reviews.apache.org/r/55942/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 55942: Added a test for validating streaming
request/response headers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55942/#review163051
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55936, 55937, 55938, 55939, 55940, 55941, 55942]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 25, 2017, 7:49 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55942/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2017, 7:49 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for validating streaming request/response headers.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
>
> Diff: https://reviews.apache.org/r/55942/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 55942: Added a test for validating streaming
request/response headers.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55942/#review163125
-----------------------------------------------------------
Patch looks great!
Reviews applied: [55936, 55937, 55938, 55939, 55978, 55940, 55941, 55942]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Jan. 26, 2017, 4:49 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55942/
> -----------------------------------------------------------
>
> (Updated Jan. 26, 2017, 4:49 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6936
> https://issues.apache.org/jira/browse/MESOS-6936
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a test for validating streaming request/response headers.
>
>
> Diffs
> -----
>
> src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
>
> Diff: https://reviews.apache.org/r/55942/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 55942: Added a test for validating streaming
request/response headers.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55942/
-----------------------------------------------------------
(Updated Jan. 26, 2017, 4:49 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comment, NNFR.
Bugs: MESOS-6936
https://issues.apache.org/jira/browse/MESOS-6936
Repository: mesos
Description
-------
Added a test for validating streaming request/response headers.
Diffs (updated)
-----
src/tests/api_tests.cpp 400ac6fcd420508509291249cad50679fbe9807d
Diff: https://reviews.apache.org/r/55942/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar