You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by Adam Lally <al...@alum.rpi.edu> on 2006/11/16 18:04:32 UTC
Somebody please figure out how to do this better (was Re: svn commit: r475808 - in /incubator/uima/uimaj/trunk/uimaj-tools/src: main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java test/java/org/apache/uima/tools/viewer/CasAnnotationViewer
I fixed a bug (reported on the forum) that the Annotation Viewer
didn't support the new primitive types. But I'm not so happy with my
fix... it involved a lot of if..else if blocks for each of the
different array types. You can get an idea of how ugly it was to
implement this just by scanning the patch quoted below. Is there a
better way? Should I create a new JIRA issue for cleaning this up?
-Adam
On 11/16/06, alally@apache.org <al...@apache.org> wrote:
> Author: alally
> Date: Thu Nov 16 08:45:08 2006
> New Revision: 475808
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=475808
> Log:
> JIRA issue UIMA-40: Fixed CasAnnotationViewer to support new primitive types.
> Also added a test case.
>
> Added:
> incubator/uima/uimaj/trunk/uimaj-tools/src/test/java/org/apache/uima/tools/viewer/CasAnnotationViewerTest.java
> Modified:
> incubator/uima/uimaj/trunk/uimaj-tools/src/main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java
>
> Modified: incubator/uima/uimaj/trunk/uimaj-tools/src/main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java
> URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-tools/src/main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java?view=diff&rev=475808&r1=475807&r2=475808
> ==============================================================================
> --- incubator/uima/uimaj/trunk/uimaj-tools/src/main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java (original)
> +++ incubator/uima/uimaj/trunk/uimaj-tools/src/main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java Thu Nov 16 08:45:08 2006
> @@ -85,11 +85,16 @@
> import org.apache.uima.cas.FSIterator;
> import org.apache.uima.cas.Feature;
> import org.apache.uima.cas.FeatureStructure;
> -import org.apache.uima.cas.FloatArrayFS;
> -import org.apache.uima.cas.IntArrayFS;
> import org.apache.uima.cas.SofaFS;
> -import org.apache.uima.cas.StringArrayFS;
> import org.apache.uima.cas.Type;
> +import org.apache.uima.cas.impl.BooleanArrayFSImpl;
> +import org.apache.uima.cas.impl.ByteArrayFSImpl;
> +import org.apache.uima.cas.impl.DoubleArrayFSImpl;
> +import org.apache.uima.cas.impl.FloatArrayFSImpl;
> +import org.apache.uima.cas.impl.IntArrayFSImpl;
> +import org.apache.uima.cas.impl.LongArrayFSImpl;
> +import org.apache.uima.cas.impl.ShortArrayFSImpl;
> +import org.apache.uima.cas.impl.StringArrayFSImpl;
> import org.apache.uima.cas.text.AnnotationFS;
> import org.apache.uima.cas.text.TCAS;
> import org.apache.uima.jcas.impl.JCas;
> @@ -204,6 +209,8 @@
> private CAS mCAS;
>
> private Type mStringType;
> +
> + private Type mFsArrayType;
>
> private boolean mConsistentColors = true;
>
> @@ -561,6 +568,7 @@
> {
> mCAS = aCAS;
> mStringType = mCAS.getTypeSystem().getType(CAS.TYPE_NAME_STRING);
> + mFsArrayType = mCAS.getTypeSystem().getType(CAS.TYPE_NAME_FS_ARRAY);
> //clear checkbox panel so it will be repopulated
> annotationCheckboxPanel.removeAll();
> entityCheckboxPanel.removeAll();
> @@ -1195,7 +1203,7 @@
> *
> * @param aAnnotation the annotation to add
> */
> - private void addAnnotationToTree(AnnotationFS aAnnotation)
> + protected void addAnnotationToTree(AnnotationFS aAnnotation)
> {
> DefaultMutableTreeNode root = (DefaultMutableTreeNode) this.selectedAnnotationTreeModel
> .getRoot();
> @@ -1255,92 +1263,11 @@
> featVal = featVal.substring(0, 64) + "...";
> }
> }
> - else if (CAS.TYPE_NAME_INTEGER.equals(rangeTypeName))
> - {
> - int intVal = aFS.getIntValue(feat);
> - featVal = Integer.toString(intVal);
> - }
> - else if (CAS.TYPE_NAME_FLOAT.equals(rangeTypeName))
> + else if (rangeType.isPrimitive())
> {
> - float floatVal = aFS.getFloatValue(feat);
> - featVal = Float.toString(floatVal);
> - }
> - else if (CAS.TYPE_NAME_STRING_ARRAY.equals(rangeTypeName))
> - {
> - StringArrayFS arrayFS = (StringArrayFS) aFS.getFeatureValue(feat);
> - StringBuffer displayVal = new StringBuffer();
> - if (arrayFS == null)
> - {
> - displayVal.append("null");
> - }
> - else
> - {
> - displayVal.append('[');
> - String[] vals = arrayFS.toArray();
> - for (int i = 0; i < vals.length - 1; i++)
> - {
> - displayVal.append(vals[i]);
> - displayVal.append(',');
> - }
> - if (vals.length > 0)
> - {
> - displayVal.append(vals[vals.length - 1]);
> - }
> - displayVal.append(']');
> - }
> - featVal = displayVal.toString();
> - }
> - else if (CAS.TYPE_NAME_INTEGER_ARRAY.equals(rangeTypeName))
> - {
> - IntArrayFS arrayFS = (IntArrayFS) aFS.getFeatureValue(feat);
> - StringBuffer displayVal = new StringBuffer();
> - if (arrayFS == null)
> - {
> - displayVal.append("null");
> - }
> - else
> - {
> - displayVal.append('[');
> - int[] vals = arrayFS.toArray();
> - for (int i = 0; i < vals.length - 1; i++)
> - {
> - displayVal.append(vals[i]);
> - displayVal.append(',');
> - }
> - if (vals.length > 0)
> - {
> - displayVal.append(vals[vals.length - 1]);
> - }
> - displayVal.append(']');
> - }
> - featVal = displayVal.toString();
> - }
> - else if (CAS.TYPE_NAME_FLOAT_ARRAY.equals(rangeTypeName))
> - {
> - FloatArrayFS arrayFS = (FloatArrayFS) aFS.getFeatureValue(feat);
> - StringBuffer displayVal = new StringBuffer();
> - if (arrayFS == null)
> - {
> - displayVal.append("null");
> - }
> - else
> - {
> - displayVal.append('[');
> - float[] vals = arrayFS.toArray();
> - for (int i = 0; i < vals.length - 1; i++)
> - {
> - displayVal.append(vals[i]);
> - displayVal.append(',');
> - }
> - if (vals.length > 0)
> - {
> - displayVal.append(vals[vals.length - 1]);
> - }
> - displayVal.append(']');
> - }
> - featVal = displayVal.toString();
> + featVal = aFS.getFeatureValueAsString(feat);
> }
> - else if (CAS.TYPE_NAME_FS_ARRAY.equals(rangeTypeName))
> + else if (mCAS.getTypeSystem().subsumes(mFsArrayType, rangeType))
> {
> ArrayFS arrayFS = (ArrayFS) aFS.getFeatureValue(feat);
> if (arrayFS != null)
> @@ -1369,7 +1296,79 @@
> }
> aParentNode.add(arrayNode);
> continue;
> - }
> + }
> + }
> + else if (rangeType.isArray()) //primitive array
> + {
> + String[] vals = null;
> + if (CAS.TYPE_NAME_STRING_ARRAY.equals(rangeTypeName))
> + {
> + StringArrayFSImpl arrayFS = (StringArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toArray();
> + }
> + else if (CAS.TYPE_NAME_INTEGER_ARRAY.equals(rangeTypeName))
> + {
> + IntArrayFSImpl arrayFS = (IntArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toStringArray();
> + }
> + else if (CAS.TYPE_NAME_FLOAT_ARRAY.equals(rangeTypeName))
> + {
> + FloatArrayFSImpl arrayFS = (FloatArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toStringArray();
> + }
> + else if (CAS.TYPE_NAME_BOOLEAN_ARRAY.equals(rangeTypeName))
> + {
> + BooleanArrayFSImpl arrayFS = (BooleanArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toStringArray();
> + }
> + else if (CAS.TYPE_NAME_BYTE_ARRAY.equals(rangeTypeName))
> + {
> + ByteArrayFSImpl arrayFS = (ByteArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toStringArray();
> + }
> + else if (CAS.TYPE_NAME_SHORT_ARRAY.equals(rangeTypeName))
> + {
> + ShortArrayFSImpl arrayFS = (ShortArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toStringArray();
> + }
> + else if (CAS.TYPE_NAME_LONG_ARRAY.equals(rangeTypeName))
> + {
> + LongArrayFSImpl arrayFS = (LongArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toStringArray();
> + }
> + if (CAS.TYPE_NAME_DOUBLE_ARRAY.equals(rangeTypeName))
> + {
> + DoubleArrayFSImpl arrayFS = (DoubleArrayFSImpl) aFS.getFeatureValue(feat);
> + if (arrayFS != null)
> + vals = arrayFS.toStringArray();
> + }
> + if (vals== null)
> + {
> + featVal = "null";
> + }
> + else
> + {
> + StringBuffer displayVal = new StringBuffer();
> + displayVal.append('[');
> + for (int i = 0; i < vals.length - 1; i++)
> + {
> + displayVal.append(vals[i]);
> + displayVal.append(',');
> + }
> + if (vals.length > 0)
> + {
> + displayVal.append(vals[vals.length - 1]);
> + }
> + displayVal.append(']');
> + featVal = displayVal.toString();
> + }
> }
> else
> //single feature value
> @@ -1832,6 +1831,16 @@
> }
> i += 2;
> }
> + }
> +
> + /**
> + * Gets the selected annotation tree component.
> + * @return the tree that displays annotation details about annotations
> + * overlapping the point where the user last clicked in the text.
> + */
> + protected JTree getSelectedAnnotationTree()
> + {
> + return this.selectedAnnotationTree;
> }
>
> /**
>
> Added: incubator/uima/uimaj/trunk/uimaj-tools/src/test/java/org/apache/uima/tools/viewer/CasAnnotationViewerTest.java
> URL: http://svn.apache.org/viewvc/incubator/uima/uimaj/trunk/uimaj-tools/src/test/java/org/apache/uima/tools/viewer/CasAnnotationViewerTest.java?view=auto&rev=475808
> ==============================================================================
> --- incubator/uima/uimaj/trunk/uimaj-tools/src/test/java/org/apache/uima/tools/viewer/CasAnnotationViewerTest.java (added)
> +++ incubator/uima/uimaj/trunk/uimaj-tools/src/test/java/org/apache/uima/tools/viewer/CasAnnotationViewerTest.java Thu Nov 16 08:45:08 2006
> @@ -0,0 +1,292 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements. See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership. The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied. See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +package org.apache.uima.tools.viewer;
> +
> +import java.util.Enumeration;
> +
> +import javax.swing.tree.DefaultMutableTreeNode;
> +import javax.swing.tree.TreeModel;
> +import javax.swing.tree.TreeNode;
> +
> +import org.apache.uima.cas.BooleanArrayFS;
> +import org.apache.uima.cas.ByteArrayFS;
> +import org.apache.uima.cas.CAS;
> +import org.apache.uima.cas.DoubleArrayFS;
> +import org.apache.uima.cas.FSIterator;
> +import org.apache.uima.cas.Feature;
> +import org.apache.uima.cas.FloatArrayFS;
> +import org.apache.uima.cas.IntArrayFS;
> +import org.apache.uima.cas.LongArrayFS;
> +import org.apache.uima.cas.ShortArrayFS;
> +import org.apache.uima.cas.StringArrayFS;
> +import org.apache.uima.cas.Type;
> +import org.apache.uima.cas.admin.CASFactory;
> +import org.apache.uima.cas.admin.CASMgr;
> +import org.apache.uima.cas.admin.FSIndexRepositoryMgr;
> +import org.apache.uima.cas.admin.TypeSystemMgr;
> +import org.apache.uima.cas.impl.CASImpl;
> +import org.apache.uima.cas.text.AnnotationFS;
> +import org.apache.uima.cas.text.TCAS;
> +import org.apache.uima.resource.metadata.TypeSystemDescription;
> +import org.apache.uima.test.junit_extension.JUnitExtension;
> +import org.apache.uima.util.CasCreationUtils;
> +
> +import junit.framework.TestCase;
> +
> +public class CasAnnotationViewerTest extends TestCase
> +{
> + CasAnnotationViewer viewer;
> +
> + private CAS cas;
> +
> + private Type annotationType;
> +
> + private Type exampleType;
> +
> + private Feature floatFeature;
> +
> + private Feature stringFeature;
> +
> + private Feature byteFeature;
> +
> + private Feature booleanFeature;
> +
> + private Feature shortFeature;
> +
> + private Feature longFeature;
> +
> + private Feature doubleFeature;
> +
> + private Feature intArrayFeature;
> +
> + private Feature floatArrayFeature;
> +
> + private Feature stringArrayFeature;
> +
> + private Feature byteArrayFeature;
> +
> + private Feature booleanArrayFeature;
> +
> + private Feature shortArrayFeature;
> +
> + private Feature longArrayFeature;
> +
> + private Feature doubleArrayFeature;
> +
> + protected void setUp() throws Exception
> + {
> + viewer = new CasAnnotationViewer();
> +
> + CASMgr casMgr = CASFactory.createCAS();
> + CasCreationUtils.setupTypeSystem(casMgr,
> + (TypeSystemDescription) null);
> + // Create a writable type system.
> + TypeSystemMgr tsa = casMgr.getTypeSystemMgr();
> + // Add new types and features.
> + annotationType = tsa.getType(TCAS.TYPE_NAME_ANNOTATION);
> + assertTrue(annotationType != null);
> +
> + // new primitive types
> + exampleType = tsa
> + .addType("test.primitives.Example", annotationType);
> +
> + floatFeature = tsa.addFeature("floatFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_FLOAT));
> + stringFeature = tsa.addFeature("stringFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_STRING));
> + booleanFeature = tsa.addFeature("boolFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_BOOLEAN));
> + byteFeature = tsa.addFeature("byteFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_BYTE));
> + shortFeature = tsa.addFeature("shortFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_SHORT));
> + longFeature = tsa.addFeature("longFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_LONG));
> + doubleFeature = tsa.addFeature("doubleFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_DOUBLE));
> +
> + intArrayFeature = tsa.addFeature("intArrayFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_INTEGER_ARRAY));
> + floatArrayFeature = tsa.addFeature("floatArrayFeature", exampleType, tsa
> + .getType(CAS.TYPE_NAME_FLOAT_ARRAY),false);
> + stringArrayFeature = tsa.addFeature("stringArrayFeature", exampleType,
> + tsa.getType(CAS.TYPE_NAME_STRING_ARRAY),false);
> + booleanArrayFeature = tsa.addFeature("boolArrayFeature",
> + exampleType, tsa.getType(CAS.TYPE_NAME_BOOLEAN_ARRAY));
> + byteArrayFeature = tsa.addFeature("byteArrayFeature", exampleType,
> + tsa.getType(CAS.TYPE_NAME_BYTE_ARRAY),false);
> + shortArrayFeature = tsa.addFeature("shortArrayFeature",
> + exampleType, tsa.getType(CAS.TYPE_NAME_SHORT_ARRAY));
> + longArrayFeature = tsa.addFeature("longArrayFeature", exampleType,
> + tsa.getType(CAS.TYPE_NAME_LONG_ARRAY));
> + doubleArrayFeature = tsa.addFeature("doubleArrayFeature",
> + exampleType, tsa.getType(CAS.TYPE_NAME_DOUBLE_ARRAY),false);
> +
> + // Commit the type system.
> + ((CASImpl)casMgr).commitTypeSystem();
> +
> + // Create the Base indexes.
> + casMgr.initCASIndexes();
> + FSIndexRepositoryMgr irm = casMgr.getIndexRepositoryMgr();
> + // init.initIndexes(irm, casMgr.getTypeSystemMgr());
> + irm.commit();
> +
> + cas = casMgr.getCAS().getView(CAS.NAME_DEFAULT_SOFA);
> +
> +
> + }
> +
> + public void testAddAnnotationToTree() throws Exception
> + {
> + try {
> + //create an annotation
> + createExampleFS(this.cas);
> + FSIterator iter = this.cas.getAnnotationIndex(exampleType).iterator();
> + AnnotationFS annot = (AnnotationFS)iter.get();
> +
> + //init viewer
> + viewer.setCAS(this.cas);
> +
> + //add to tree
> + viewer.addAnnotationToTree(annot);
> +
> + //inspect results
> + TreeModel model = viewer.getSelectedAnnotationTree().getModel();
> + DefaultMutableTreeNode root = (DefaultMutableTreeNode)model.getRoot();
> + assertEquals("Annotations", root.getUserObject().toString());
> + DefaultMutableTreeNode typeNode = (DefaultMutableTreeNode)root.getChildAt(0);
> + assertEquals("Example", typeNode.getUserObject().toString());
> + DefaultMutableTreeNode fsNode = (DefaultMutableTreeNode)typeNode.getChildAt(0);
> + Enumeration children = fsNode.children();
> + assertEquals("begin = 1", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("end = 5", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("floatFeature = " + (float)99.99, ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("stringFeature = aaaaaaa", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("boolFeature = true", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("byteFeature = 122", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("shortFeature = " + Short.MIN_VALUE, ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("longFeature = " + Long.MIN_VALUE, ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("doubleFeature = " + Double.MAX_VALUE, ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> +
> + assertEquals("intArrayFeature = [" + Integer.MAX_VALUE + "," + (Integer.MAX_VALUE-1) + ",42," + (Integer.MIN_VALUE+1) + "," + Integer.MIN_VALUE + "]",
> + ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("floatArrayFeature = [" + Float.MAX_VALUE + "," + (float)(Float.MAX_VALUE/1000.0) + "," + 42.0 + "," + (float)(Float.MIN_VALUE*1000) + "," + Float.MIN_VALUE + "]",
> + ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("stringArrayFeature = [zzzzzz,yyyyyy,xxxxxx,wwwwww,vvvvvv]", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("boolArrayFeature = [true,false,true,false,true,false,true,false]", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("byteArrayFeature = [8,16,64,-128,-1]", ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("shortArrayFeature = [" + Short.MAX_VALUE + "," + (Short.MAX_VALUE-1) + "," + (Short.MAX_VALUE-2) + "," + (Short.MAX_VALUE-3) + "," + (Short.MAX_VALUE-4) + "]",
> + ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("longArrayFeature = [" + Long.MAX_VALUE + "," + (Long.MAX_VALUE-1) + "," + (Long.MAX_VALUE-2) + "," + (Long.MAX_VALUE-3) + "," + (Long.MAX_VALUE-4) + "]",
> + ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> + assertEquals("doubleArrayFeature = [" + Double.MAX_VALUE + "," + Double.MIN_VALUE + "," + Double.parseDouble("1.5555") + "," + Double.parseDouble("99.000000005") + "," + Double.parseDouble("4.44444444444444444") + "]",
> + ((DefaultMutableTreeNode)children.nextElement()).getUserObject().toString());
> +
> + } catch (Exception e) {
> + JUnitExtension.handleException(e);
> + }
> + }
> +
> + private void createExampleFS(CAS cas) throws Exception {
> + // Set the document text
> + cas.setDocumentText("this beer is good");
> +
> + // create an FS of exampleType and index it
> + AnnotationFS fs = cas.createAnnotation(exampleType, 1, 5);
> + cas.getIndexRepository().addFS(fs);
> +
> + // create Array FSs
> + StringArrayFS strArrayFS = cas.createStringArrayFS(5);
> + strArrayFS.set(0, "zzzzzz");
> + strArrayFS.set(1, "yyyyyy");
> + strArrayFS.set(2, "xxxxxx");
> + strArrayFS.set(3, "wwwwww");
> + strArrayFS.set(4, "vvvvvv");
> +
> + IntArrayFS intArrayFS = cas.createIntArrayFS(5);
> + intArrayFS.set(0, Integer.MAX_VALUE);
> + intArrayFS.set(1, Integer.MAX_VALUE-1);
> + intArrayFS.set(2, 42);
> + intArrayFS.set(3, Integer.MIN_VALUE+1);
> + intArrayFS.set(4, Integer.MIN_VALUE);
> +
> + FloatArrayFS floatArrayFS = cas.createFloatArrayFS(5);
> + floatArrayFS.set(0, Float.MAX_VALUE);
> + floatArrayFS.set(1, (float) (Float.MAX_VALUE/1000.0));
> + floatArrayFS.set(2, (float) 42);
> + floatArrayFS.set(3, (float) (Float.MIN_VALUE*1000.0));
> + floatArrayFS.set(4, Float.MIN_VALUE);
> +
> + ByteArrayFS byteArrayFS = cas.createByteArrayFS(5);
> + byteArrayFS.set(0, (byte)8);
> + byteArrayFS.set(1, (byte)16);
> + byteArrayFS.set(2, (byte)64);
> + byteArrayFS.set(3, (byte)128);
> + byteArrayFS.set(4, (byte)255);
> +
> + BooleanArrayFS boolArrayFS = cas.createBooleanArrayFS(8);
> + boolean val = false;
> + for (int i=0; i<8; i++) {
> + boolArrayFS.set(i,val=!val);
> + }
> +
> + ShortArrayFS shortArrayFS = cas.createShortArrayFS(5);
> + shortArrayFS.set(0, Short.MAX_VALUE);
> + shortArrayFS.set(1, (short) (Short.MAX_VALUE - 1));
> + shortArrayFS.set(2, (short) (Short.MAX_VALUE - 2));
> + shortArrayFS.set(3, (short) (Short.MAX_VALUE - 3));
> + shortArrayFS.set(4, (short) (Short.MAX_VALUE - 4));
> +
> + LongArrayFS longArrayFS = cas.createLongArrayFS(5);
> + longArrayFS.set(0, Long.MAX_VALUE);
> + longArrayFS.set(1, Long.MAX_VALUE - 1);
> + longArrayFS.set(2, Long.MAX_VALUE - 2);
> + longArrayFS.set(3, Long.MAX_VALUE - 3);
> + longArrayFS.set(4, Long.MAX_VALUE - 4);
> +
> + DoubleArrayFS doubleArrayFS = cas.createDoubleArrayFS(5);
> + doubleArrayFS.set(0, Double.MAX_VALUE);
> + doubleArrayFS.set(1, Double.MIN_VALUE);
> + doubleArrayFS.set(2, Double.parseDouble("1.5555"));
> + doubleArrayFS.set(3, Double.parseDouble("99.000000005"));
> + doubleArrayFS.set(4, Double.parseDouble("4.44444444444444444"));
> +
> + // set features of fs
> + fs.setStringValue(stringFeature, "aaaaaaa");
> + fs.setFloatValue(floatFeature, (float) 99.99);
> +
> + fs.setFeatureValue(intArrayFeature, intArrayFS);
> + fs.setFeatureValue(floatArrayFeature, floatArrayFS);
> + fs.setFeatureValue(stringArrayFeature, strArrayFS);
> +
> + //fs.setByteValue(byteFeature, Byte.MAX_VALUE);
> + fs.setByteValue(byteFeature,(byte) 'z');
> + fs.setFeatureValue(byteArrayFeature, byteArrayFS);
> + fs.setBooleanValue(booleanFeature, true);
> + fs.setFeatureValue(booleanArrayFeature, boolArrayFS);
> + fs.setShortValue(shortFeature, Short.MIN_VALUE);
> + fs.setFeatureValue(shortArrayFeature, shortArrayFS);
> + fs.setLongValue(longFeature, Long.MIN_VALUE);
> + fs.setFeatureValue(longArrayFeature, longArrayFS);
> + fs.setDoubleValue(doubleFeature, Double.MAX_VALUE);
> + fs.setFeatureValue(doubleArrayFeature, doubleArrayFS);
> +
> + cas.getIndexRepository().addFS(fs);
> +}
> +}
>
>
>
Re: Somebody please figure out how to do this better (was Re: svn
commit: r475808 - in /incubator/uima/uimaj/trunk/uimaj-tools/src: main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java
test/java/org/apache/uima/tools/viewer/CasAnnotationViewer
Posted by Thilo Goetz <tw...@gmx.de>.
I apologize, maybe I should get glasses. Everything's there, I just
didn't see it.
Marshall Schor wrote:
> Best not to ascribe blame for these, I think. This may have in fact
> been my oversight :-)
>
> -Marshall
>
> Thilo Goetz wrote:
>> Adam Lally wrote:
>>> I fixed a bug (reported on the forum) that the Annotation Viewer
>>> didn't support the new primitive types. But I'm not so happy with my
>>> fix... it involved a lot of if..else if blocks for each of the
>>> different array types. You can get an idea of how ugly it was to
>>> implement this just by scanning the patch quoted below. Is there a
>>> better way? Should I create a new JIRA issue for cleaning this up?
>>>
>>> -Adam
>>
>> I was going to answer "you can use LowLevelCAS.ll_getTypeClass(int
>> typeCode)" but I see that Bhavani failed to update that method for the
>> new types. I will have to deal with the same thing in the CVD one of
>> these days. When I do, I'll go back to the annotation viewer and see
>> if I can straighten things out.
>>
>> --Thilo
>>
>>
>>
Re: Somebody please figure out how to do this better (was Re: svn
commit: r475808 - in /incubator/uima/uimaj/trunk/uimaj-tools/src: main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java
test/java/org/apache/uima/tools/viewer/CasAnnotationViewer
Posted by Marshall Schor <ms...@schor.com>.
Best not to ascribe blame for these, I think. This may have in fact
been my oversight :-)
-Marshall
Thilo Goetz wrote:
> Adam Lally wrote:
>> I fixed a bug (reported on the forum) that the Annotation Viewer
>> didn't support the new primitive types. But I'm not so happy with my
>> fix... it involved a lot of if..else if blocks for each of the
>> different array types. You can get an idea of how ugly it was to
>> implement this just by scanning the patch quoted below. Is there a
>> better way? Should I create a new JIRA issue for cleaning this up?
>>
>> -Adam
>
> I was going to answer "you can use LowLevelCAS.ll_getTypeClass(int
> typeCode)" but I see that Bhavani failed to update that method for the
> new types. I will have to deal with the same thing in the CVD one of
> these days. When I do, I'll go back to the annotation viewer and see
> if I can straighten things out.
>
> --Thilo
>
>
>
Re: Somebody please figure out how to do this better (was Re: svn
commit: r475808 - in /incubator/uima/uimaj/trunk/uimaj-tools/src: main/java/org/apache/uima/tools/viewer/CasAnnotationViewer.java
test/java/org/apache/uima/tools/viewer/CasAnnotationViewer
Posted by Thilo Goetz <tw...@gmx.de>.
Adam Lally wrote:
> I fixed a bug (reported on the forum) that the Annotation Viewer
> didn't support the new primitive types. But I'm not so happy with my
> fix... it involved a lot of if..else if blocks for each of the
> different array types. You can get an idea of how ugly it was to
> implement this just by scanning the patch quoted below. Is there a
> better way? Should I create a new JIRA issue for cleaning this up?
>
> -Adam
I was going to answer "you can use LowLevelCAS.ll_getTypeClass(int
typeCode)" but I see that Bhavani failed to update that method for the
new types. I will have to deal with the same thing in the CVD one of
these days. When I do, I'll go back to the annotation viewer and see if
I can straighten things out.
--Thilo