You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wayang.apache.org by "mohit-devlogs (via GitHub)" <gi...@apache.org> on 2026/03/05 07:34:22 UTC
[PR] Improve JdbcExecutor traversal by safely handling missing or multiple consumers [wayang]
mohit-devlogs opened a new pull request, #711:
URL: https://github.com/apache/wayang/pull/711
This change improves the robustness of JdbcExecutor by relaxing the assumption that the retrieval of consumers from the output channel is a singleton.
In the previous code, the function findJdbcExecutionOperatorTaskInStage() in the class WayangJdbcExecutor used the function WayangCollections.getSingle() for the retrieval of consumers from the output channel. The function throws an IllegalArgumentException if the list of consumers is empty or if there are more than one consumers in the list.
Changes:
- More robust code is now used in place of WayangCollections.getSingle()
- Return null if no consumer exists (i.e., it is the last in the pipeline)
- Throw a Wayang exception if there are more than one consumers
This prevents crashes like this:
IllegalArgumentException: [] is not a singleton
Testing:
- Compilation checked
- Tested with:
mvn -pl wayang-platforms/wayang-generic-jdbc test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve JdbcExecutor traversal by safely handling missing or multiple consumers [wayang]
Posted by "mohit-devlogs (via GitHub)" <gi...@apache.org>.
mohit-devlogs commented on PR #711:
URL: https://github.com/apache/wayang/pull/711#issuecomment-5066113482
@novatechflow I recreated this change on top of the latest main because rebasing this branch resulted in extensive conflicts after upstream changes. The updated PR is #785. I'll close this PR so the review can continue there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve JdbcExecutor traversal by safely handling missing or multiple consumers [wayang]
Posted by "novatechflow (via GitHub)" <gi...@apache.org>.
novatechflow commented on PR #711:
URL: https://github.com/apache/wayang/pull/711#issuecomment-5022189069
@mohit-devlogs - the PR conflicts with the current base, please rebase and follow up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve JdbcExecutor traversal by safely handling missing or multiple consumers [wayang]
Posted by "mohit-devlogs (via GitHub)" <gi...@apache.org>.
mohit-devlogs closed pull request #711: Improve JdbcExecutor traversal by safely handling missing or multiple consumers
URL: https://github.com/apache/wayang/pull/711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org