You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "0lai0 (via GitHub)" <gi...@apache.org> on 2023/04/26 03:37:39 UTC
[GitHub] [yunikorn-core] 0lai0 opened a new pull request, #532: [YUNIKORN-1700] Fix the wrong objects comparing in the Yunikorn-core …
0lai0 opened a new pull request, #532:
URL: https://github.com/apache/yunikorn-core/pull/532
### What is this PR for?
In the FIFO policy, sorting applications is wrong.
Because `r.SubmissionTime.Before(r.SubmissionTime) is useless comparison in the FIFO `
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1700
### How should this be tested?
make test
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] codecov[bot] commented on pull request #532: [YUNIKORN-1700] Fix the wrong objects comparing in the Yunikorn-core sorts.go
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #532:
URL: https://github.com/apache/yunikorn-core/pull/532#issuecomment-1522739189
## [Codecov](https://codecov.io/gh/apache/yunikorn-core/pull/532?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#532](https://codecov.io/gh/apache/yunikorn-core/pull/532?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1389247) into [master](https://codecov.io/gh/apache/yunikorn-core/commit/80d9290bc9cfbf37c1efb2d18e2b136f6b167e33?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (80d9290) will **increase** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #532 +/- ##
==========================================
+ Coverage 75.04% 75.05% +0.01%
==========================================
Files 70 70
Lines 11327 11327
==========================================
+ Hits 8500 8502 +2
+ Misses 2529 2528 -1
+ Partials 298 297 -1
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-core/pull/532?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/scheduler/objects/sorters.go](https://codecov.io/gh/apache/yunikorn-core/pull/532?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3NjaGVkdWxlci9vYmplY3RzL3NvcnRlcnMuZ28=) | `98.20% <100.00%> (+1.19%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-core] wilfred-s closed pull request #532: [YUNIKORN-1700] Fix the wrong objects comparing in the Yunikorn-core sorts.go
Posted by "wilfred-s (via GitHub)" <gi...@apache.org>.
wilfred-s closed pull request #532: [YUNIKORN-1700] Fix the wrong objects comparing in the Yunikorn-core sorts.go
URL: https://github.com/apache/yunikorn-core/pull/532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org