You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/11 11:28:54 UTC
[GitHub] [cloudstack] ravening opened a new pull request #4076: Support searching vm's by multiple id
ravening opened a new pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076
## Description
Add support to list virtual machines by multiple ids (not uuid)
In older version of cloudstacj, the vm id's are stored as
integer and not as UUID's. Currently it supports searching for
VM's using multiple UUID's but not possible to search VM's
using multiple ID's
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## Screenshots (if appropriate):
## How Has This Been Tested?
Before the fix below api calls didnt work
```
(local) > list virtualmachines ids=1697,1698,1699 listall=true
```
After the fix it will work
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md) document -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-628497213
@ravening, did you check that searching for UUIDs still works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-643531296
@ravening we don't want end-users to be able to list resources by integer IDs; the support we've is largely to keep some of the APIs/params compatible. Given the API indeed works when multiple comma-separated IDs (uuids/strings) are passed, the support for searching by multiple IDs already works.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-630073008
> @ravening the 4.4 sound like a search blocker only for a specific version or what do you think?
@svenvogel "since=4.4" indicates that its only supported from version 4.4 onwards. Since there was "id's" instead of "uuid" before 4.4, search for list of "id's" is not possible. Removing it will ensure that we can search it in any version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-628773000
> @ravening, did you check that searching for UUIDs still works?
yes search multiple uuid or single uuid still works
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
rhtyd closed pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-653724428
Closing on previous remark and no further communication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-630742220
@ravening, so did you find out what caused this to work this way? The chance seems so unrelated to your objectives that it reeks of an undesirable side effect.
also, did you try removing the since attribute altogether?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-630195800
@ravening are you running a pre-4.4 version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
ravening commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-630258472
> @ravening are you running a pre-4.4 version?
Not anymore. There were few vm's which were created on 4.2 version and when upgraded to 4.7, listing vm's with multiple id's(not uuid's) didnt work anymore.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] svenvogel commented on pull request #4076: Support searching vm's by multiple id
Posted by GitBox <gi...@apache.org>.
svenvogel commented on pull request #4076:
URL: https://github.com/apache/cloudstack/pull/4076#issuecomment-629248052
@ravening the 4.4 sound like a search blocker only for a specific version or what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org