You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Hyukjin Kwon (JIRA)" <ji...@apache.org> on 2019/04/02 23:29:00 UTC
[jira] [Assigned] (SPARK-27346) Loosen the newline assert condition
on 'examples' field in ExpressionInfo
[ https://issues.apache.org/jira/browse/SPARK-27346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyukjin Kwon reassigned SPARK-27346:
------------------------------------
Assignee: Hyukjin Kwon
> Loosen the newline assert condition on 'examples' field in ExpressionInfo
> -------------------------------------------------------------------------
>
> Key: SPARK-27346
> URL: https://issues.apache.org/jira/browse/SPARK-27346
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 2.4.1, 3.0.0
> Reporter: Hyukjin Kwon
> Assignee: Hyukjin Kwon
> Priority: Trivial
>
> I haven't tested by myself on Windows and I am not 100% sure if this is going to cause an actual problem.
> The codes here:
> {code}
> assert examples.isEmpty() || examples.startsWith(System.lineSeparator() + " Examples:");
> {code}
> Given my speculation, if Spark is built in Linux, and it's executed on Windows, it looks possible to throw an exception because encoded newline in the binary is {{\n}} but {{System.lineSeparator}} returns {{\r\n}}.
> I haven't tested it by myself but I think it's better to loosen the condition and forget about this problem.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org