You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/03 04:21:44 UTC

[GitHub] [spark] srowen commented on a change in pull request #30580: [SPARK-33636][PYTHON][ML][3.0] Add labelsArray to PySpark StringIndexer

srowen commented on a change in pull request #30580:
URL: https://github.com/apache/spark/pull/30580#discussion_r534657283



##########
File path: python/pyspark/ml/feature.py
##########
@@ -3765,6 +3765,15 @@ def labels(self):
         """

Review comment:
       Adding the deprecation note to labels? yeah that could be fine, but not essential here. Either way.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org