You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2018/03/06 16:51:24 UTC
commons-io git commit: Refactor magic string into a constant.
Repository: commons-io
Updated Branches:
refs/heads/master 8f957f527 -> f03149e07
Refactor magic string into a constant.
Project: http://git-wip-us.apache.org/repos/asf/commons-io/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-io/commit/f03149e0
Tree: http://git-wip-us.apache.org/repos/asf/commons-io/tree/f03149e0
Diff: http://git-wip-us.apache.org/repos/asf/commons-io/diff/f03149e0
Branch: refs/heads/master
Commit: f03149e07dee90b23369d1cdb7f15c142df5e31d
Parents: 8f957f5
Author: Gary Gregory <ga...@gmail.com>
Authored: Tue Mar 6 09:51:21 2018 -0700
Committer: Gary Gregory <ga...@gmail.com>
Committed: Tue Mar 6 09:51:21 2018 -0700
----------------------------------------------------------------------
src/main/java/org/apache/commons/io/FilenameUtils.java | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-io/blob/f03149e0/src/main/java/org/apache/commons/io/FilenameUtils.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/commons/io/FilenameUtils.java b/src/main/java/org/apache/commons/io/FilenameUtils.java
index 4ef121b..170c7ef 100644
--- a/src/main/java/org/apache/commons/io/FilenameUtils.java
+++ b/src/main/java/org/apache/commons/io/FilenameUtils.java
@@ -81,6 +81,8 @@ import java.util.Stack;
*/
public class FilenameUtils {
+ private static final String EMPTY_STRING = "";
+
private static final int NOT_FOUND = -1;
/**
@@ -430,7 +432,7 @@ public class FilenameUtils {
}
if (size <= 0) { // should never be less than 0
- return "";
+ return EMPTY_STRING;
}
if (size <= prefix) { // should never be less than prefix
return new String(array, 0, size);
@@ -859,7 +861,7 @@ public class FilenameUtils {
final int index = indexOfLastSeparator(filename);
final int endIndex = index+separatorAdd;
if (prefix >= filename.length() || index < 0 || prefix >= endIndex) {
- return "";
+ return EMPTY_STRING;
}
final String path = filename.substring(prefix, endIndex);
failIfNullBytePresent(path);
@@ -1056,7 +1058,7 @@ public class FilenameUtils {
}
final int index = indexOfExtension(filename);
if (index == NOT_FOUND) {
- return "";
+ return EMPTY_STRING;
}
return filename.substring(index + 1);
}