You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2021/05/01 18:25:32 UTC

[GitHub] [cxf] dblevins commented on pull request #782: CXF-8518: Fixing jaxrs.spec.provider.standardnotnull clientJaxbProviderTest

dblevins commented on pull request #782:
URL: https://github.com/apache/cxf/pull/782#issuecomment-830674441


   I like this better than my too-brittle hack :)
   
    - https://github.com/dblevins/cxf/commit/32103901420a7811f1b5af0c37e9bf797fac8b81
   
   The one concern I'd have is that `inputStream.available()` is a guess and could potentially return zero when there is a valid payload coming.  That might happen in scenarios where the server-side could just be taking a while streaming back the payload.
   
   I wonder if we wrapped the input stream instead of returning null and had the wrapper count the bytes read.  We could check the count on an exception and use that to determine our blocking read returned no payload.
   
   It'd be sort of a hybrid of the two approaches.  Thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org