You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Graeme-Miller <gi...@git.apache.org> on 2017/09/14 11:58:45 UTC
[GitHub] brooklyn-server pull request #823: Fix creation script
GitHub user Graeme-Miller opened a pull request:
https://github.com/apache/brooklyn-server/pull/823
Fix creation script
An issue was created by https://github.com/apache/brooklyn-server/pull/812.
That PR removed the password needed to create the user brooklyn'@'localhost
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Graeme-Miller/brooklyn-server patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/823.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #823
----
commit 413aa2cf9cf2593bef33482796892c1370dd2f78
Author: Graeme-Miller <gr...@cloudsoftcorp.com>
Date: 2017-09-14T11:52:06Z
Update visitors-creation-script.sql
commit 5a8e2d0e66cdfa32bff057cfce238c9b3785d8cf
Author: Graeme-Miller <gr...@cloudsoftcorp.com>
Date: 2017-09-14T11:53:11Z
Update visitors-creation-script.sql
----
---
[GitHub] brooklyn-server issue #823: Fix creation script
Posted by Graeme-Miller <gi...@git.apache.org>.
Github user Graeme-Miller commented on the issue:
https://github.com/apache/brooklyn-server/pull/823
I have tested this on a MySQLNode and it works
---
[GitHub] brooklyn-server pull request #823: Fix creation script
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/823
---
[GitHub] brooklyn-server issue #823: Fix creation script
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/823
@Graeme-Miller @drigodwin odd - local seemed to work for me but sometimes mysql is weird which NIC/socket it uses for localhost, and different versions are different. good fix.
two things--
* is the same update made to brooklyn-library ?
* is there a reason we're not consistent what perms we give to the two users? (this PR gives `usage` to the users @ `%` but `all` to @ `localhost` -- previously was `all on visitors` and `usage` elsewhere, to both users) ... in other words should the file read
```
grant usage on *.* to 'brooklyn'@'%' identified by '${config["creation.script.password"]!"br00k11n"}';
grant all privileges on visitors.* to 'brooklyn'@'%';
# useful if sockets work also
grant all privileges on *.* to 'brooklyn'@'localhost' identified by '${config["creation.script.password"]!"br00k11n"}';
grant all privileges on visitors.* to 'brooklyn'@'localhost';
```
---