You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/07 05:23:10 UTC

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4380: RBD: support multiple MON hosts

sureshanaparti commented on a change in pull request #4380:
URL: https://github.com/apache/cloudstack/pull/4380#discussion_r500744207



##########
File path: plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/lifecycle/CloudStackPrimaryDataStoreLifeCycleImpl.java
##########
@@ -141,6 +141,9 @@ public DataStore initialize(Map<String, Object> dsInfos) {
 
         URI uri = null;
         try {
+            if (url != null && url.startsWith("rbd://")) {

Review comment:
       in case the url scheme is not case sensitive, can use:
   
   ```suggestion
               if (url != null && url..toLowerCase().startsWith("rbd://")) {
   ```
   
   (or)
   
   ```suggestion
               if (StringUtils.startsWithIgnoreCase(url, "rbd://")) {
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org