You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/09 07:59:20 UTC
[GitHub] [apisix] guoqqqi opened a new issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
guoqqqi opened a new issue #6559:
URL: https://github.com/apache/apisix/issues/6559
### Improved or typo fixed.
remove the `make install`
### Solution
Since `make install` is not an installation dependency and may cause some misunderstanding to the user, we should add some extra comments to it or remove `make install`
Any better suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1063575079
The original discussion is here: https://github.com/apache/apisix/pull/5136#discussion_r716058656
Maybe we still need to remove the `make install` cc @spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] bin-ya commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
bin-ya commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1064883036
Remove make install or change the comment to Install the apisix (only for luarocks)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1063718432
Is `make install` a misleading name? How about change to `make luarocks-init`?
In fact, Apache APISIX does not need to install after downloading the source code, it can be run directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] guoqqqi commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1064089601
> How about changing to `make luarocks-init`?
> Apache APISIX does not need to install after downloading the source code, it can be run directly after `make deps`.
+1 If changing the command would be tricky, We can start by adding some comments to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming edited a comment on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
moonming edited a comment on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1063718432
Is `make install` a misleading name? How about changing to `make luarocks-init`?
In fact, Apache APISIX does not need to `install` after downloading the source code, it can be run directly after `make deps`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1062657441
Could you please describe the `reason` why we need to remove this? and what misunderstanding?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #6559:
URL: https://github.com/apache/apisix/issues/6559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] juzhiyuan edited a comment on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
juzhiyuan edited a comment on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1062657441
Could you please describe the `reason` why we need to remove this? and what misunderstanding? 🤗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
hf400159 commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1062657651
I think we should add some extra comments to it, because someone needs it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1066024365
I think it would be better to remove `make install` (in that context).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #6559: docs: remove the `make install` in how to build Apache APISIX doc
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #6559:
URL: https://github.com/apache/apisix/issues/6559#issuecomment-1064670029
Yes. Since the `make install` is designed by luarocks, would be better to create a new name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org