You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/01/06 09:44:36 UTC
[GitHub] [buildstream] juergbi commented on a change in pull request #1436: .github/workflows/ci.yml: Test current supported Fedora 33
juergbi commented on a change in pull request #1436:
URL: https://github.com/apache/buildstream/pull/1436#discussion_r552470620
##########
File path: .github/workflows/ci.yml
##########
@@ -34,8 +34,8 @@ jobs:
env:
CI_IMAGE_PREFIX: registry.gitlab.com/buildstream/buildstream-docker-images/testsuite
- CI_IMAGE_SUFFIX: master-177137613
- TOXENV: py36,py37,py38-nocover,py36-plugins,py37-plugins,py38-plugins-nocover
+ CI_IMAGE_SUFFIX: master-236878594
+ TOXENV: py36,py37,py38-nocover,py36-plugins,py37-plugins,py38-plugins-nocover,py39
Review comment:
I think it should be `py39-nocover` as coverage support is broken in Python 3.8 and later. At least that was the setting in GitLab CI and also matches `tox.ini`. Also, we should add both `py39-nocover` (right after `py38-nocover`) and `py39-plugins-nocover` (at the end).
##########
File path: .github/workflows/ci.yml
##########
@@ -34,8 +34,8 @@ jobs:
env:
CI_IMAGE_PREFIX: registry.gitlab.com/buildstream/buildstream-docker-images/testsuite
- CI_IMAGE_SUFFIX: master-177137613
- TOXENV: py36,py37,py38-nocover,py36-plugins,py37-plugins,py38-plugins-nocover
+ CI_IMAGE_SUFFIX: master-236878594
Review comment:
Can we please keep all the CI image versions in sync? Unfortunately, the image suffix is duplicated multiple times in `ci.yml` and also in `merge.yml` and `release.yml`. Let's keep them in sync manually as long as we can't fix this duplication.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org