You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Isabel Jimenez <co...@isabeljimenez.com> on 2015/10/07 21:10:29 UTC
Review Request 39099: Changed secret field in Credential from 'bytes'
to 'string' for V1
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
This change is introduced in dependant patch and we should update V1 proto as well.
Diffs
-----
include/mesos/v1/mesos.proto eadbc9d
Diff: https://reviews.apache.org/r/39099/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 39099: Changed secret field in Credential from
'bytes' to 'string' for V1
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/#review102416
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On 十月 13, 2015, 8 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39099/
> -----------------------------------------------------------
>
> (Updated 十月 13, 2015, 8 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change is introduced in dependant patch and we should update V1 proto as well.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.proto eadbc9d
>
> Diff: https://reviews.apache.org/r/39099/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39099: Changed secret field in Credential from
'bytes' to 'string' for V1
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/#review102423
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39098, 39099]
All tests passed.
- Mesos ReviewBot
On Oct. 13, 2015, 8 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39099/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 8 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change is introduced in dependant patch and we should update V1 proto as well.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.proto eadbc9d
>
> Diff: https://reviews.apache.org/r/39099/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39099: Changed secret field in Credential from
'bytes' to 'string' for V1
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/#review102501
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Oct. 13, 2015, 8 a.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39099/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 8 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change is introduced in dependant patch and we should update V1 proto as well.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.proto eadbc9d
>
> Diff: https://reviews.apache.org/r/39099/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>
Re: Review Request 39099: Changed secret field in Credential from
'bytes' to 'string' for V1
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/
-----------------------------------------------------------
(Updated Oct. 13, 2015, 8 a.m.)
Review request for mesos and Michael Park.
Changes
-------
rebase
Repository: mesos
Description
-------
This change is introduced in dependant patch and we should update V1 proto as well.
Diffs (updated)
-----
include/mesos/v1/mesos.proto eadbc9d
Diff: https://reviews.apache.org/r/39099/diff/
Testing
-------
make check
Thanks,
Isabel Jimenez
Re: Review Request 39099: Changed secret field in Credential from
'bytes' to 'string' for V1
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39099/#review102225
-----------------------------------------------------------
This one need a rebase
- Guangya Liu
On 十月 7, 2015, 7:10 p.m., Isabel Jimenez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39099/
> -----------------------------------------------------------
>
> (Updated 十月 7, 2015, 7:10 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change is introduced in dependant patch and we should update V1 proto as well.
>
>
> Diffs
> -----
>
> include/mesos/v1/mesos.proto eadbc9d
>
> Diff: https://reviews.apache.org/r/39099/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Isabel Jimenez
>
>