[GitHub] sijie commented on a change in pull request #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1012: [Merge Yahoo repo] CMS-1437: use BookieSocketAddress in DNSToSwitchMapping
URL: https://github.com/apache/bookkeeper/pull/1012#discussion_r162429839
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/net/NetUtils.java
 ##########
 @@ -68,18 +66,13 @@ public static String normalizeHostName(String name) {
         return hostNames;
     }
 
-    public static String resolveNetworkLocation(DNSToSwitchMapping dnsResolver, InetSocketAddress addr) {
-        List<String> names = new ArrayList<String>(1);
-
-        if (dnsResolver.useHostName()) {
 
 Review comment:
   I didn't see where this logic is moved to. I think this change will also break `useHostName()`. and the tests doesn't catch this, so it means that we are missing some tests to cover this. we need to add a test to cover `useHostName`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services