[GitHub] [phoenix] kadirozde commented on a change in pull request #846: PHOENIX-6045 Delete that should qualify for index path does not use i…

[GitBox <gi...@apache.org>]

kadirozde commented on a change in pull request #846:
URL: https://github.com/apache/phoenix/pull/846#discussion_r461777313



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java
##########
@@ -486,19 +494,22 @@ else if (table.isTransactional() && connection.getSCN() != null) {
             projectedColumns.add(column);
             aliasedNodes.add(FACTORY.aliasedNode(null, FACTORY.column(null, '"' + column.getName().getString() + '"', null)));
         }
-        // Project all non PK indexed columns so that we can do the proper index maintenance
+        // Project all non PK indexed columns so that we can do the proper index maintenance on the indexes for which
+        // mutations are generated on the client side. Indexed columns are needed to identify index rows to be deleted
         for (PTable index : table.getIndexes()) {

Review comment:
       Possibly but I have tested this code and do not want to go through the whole testing cycle which includes testing on a real cluster as this is a production issue for us now. Thanks for the suggestion




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org