You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@openmeetings.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/10/18 06:26:00 UTC

[jira] [Commented] (OPENMEETINGS-2692) Update manifest file path to use application.base.url

    [ https://issues.apache.org/jira/browse/OPENMEETINGS-2692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429833#comment-17429833 ] 

ASF subversion and git services commented on OPENMEETINGS-2692:
---------------------------------------------------------------

Commit 92e19ec9d4705c0124a28ed5a3467e1e54d0ce2c in openmeetings's branch refs/heads/feature/OPENMEETINGS-2692-update-webapp-path-for-manifest-references from Sebastian Wagner
[ https://gitbox.apache.org/repos/asf?p=openmeetings.git;h=92e19ec ]

OPENMEETINGS-2692 Update manifest to get webapp name from base URL config.


> Update manifest file path to use application.base.url
> -----------------------------------------------------
>
>                 Key: OPENMEETINGS-2692
>                 URL: https://issues.apache.org/jira/browse/OPENMEETINGS-2692
>             Project: Openmeetings
>          Issue Type: Task
>          Components: Mobile client
>    Affects Versions: 7.0.0
>            Reporter: Sebastian Wagner
>            Assignee: Sebastian Wagner
>            Priority: Major
>             Fix For: 7.0.0
>
>
> Address webapp path.
>  
> [~solomax]: 
> {quote}this might be very inaccurate
>  for ex. OpenmeetingsVariables.getApplicationName() == OpenMeetings - Next
>  
> I believe it's better to use application.base.url for this
>  
> And since this is calculated I would create and pass variable or create method for this
> {quote}
>  
> See: [https://github.com/apache/openmeetings/pull/164#discussion_r730433443]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)