You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/29 17:01:38 UTC
[GitHub] [beam] pabloem commented on a diff in pull request #22792: [Playground] [Backend] added SDK validation to save a code snippet
pabloem commented on code in PR #22792:
URL: https://github.com/apache/beam/pull/22792#discussion_r957581552
##########
playground/backend/cmd/server/controller_test.go:
##########
@@ -863,7 +863,7 @@ func TestPlaygroundController_SaveSnippet(t *testing.T) {
t.Errorf("PlaygroundController_SaveSnippet() error = %v, wantErr %v", err, tt.wantErr)
}
if err == nil {
- if len(got.Id) != 11 || got.Id != tt.wantId {
+ if len(got.Id) != 11 {
Review Comment:
why is the length always 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org