You are viewing a plain text version of this content. The canonical link for it is here.

Posted to user@ofbiz.apache.org by Raj Saini <ra...@gmail.com> on 2008/01/21 10:41:49 UTC

Duplicate code in TaxAuthorityServices#getTaxAuthorities method

Hi,

Line numbers 212-214 of the said method looks duplicate of 206-208. It 
may not be harmful as Set can not have duplicate values.

Please confirm if it is a bug, I will create a Jira and patch.

Thanks,

Raj

Re: Duplicate code in TaxAuthorityServices#getTaxAuthorities method

Posted by Raj Saini <ra...@gmail.com>.

Thanks Jacques, seems I am getting older ;)

Raj
Jacques Le Roux wrote:
> Raj,
>
> country is not county ;o)
>
> Jacques
>
> From: "Raj Saini" <ra...@gmail.com>
>> Hi,
>>
>> Line numbers 212-214 of the said method looks duplicate of 206-208. 
>> It may not be harmful as Set can not have duplicate values.
>>
>> Please confirm if it is a bug, I will create a Jira and patch.
>>
>> Thanks,
>>
>> Raj
>>
>

Re: Duplicate code in TaxAuthorityServices#getTaxAuthorities method

Posted by Jacques Le Roux <ja...@les7arts.com>.

Raj,

country is not county ;o)

Jacques

From: "Raj Saini" <ra...@gmail.com>
> Hi,
> 
> Line numbers 212-214 of the said method looks duplicate of 206-208. It 
> may not be harmful as Set can not have duplicate values.
> 
> Please confirm if it is a bug, I will create a Jira and patch.
> 
> Thanks,
> 
> Raj
>