You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mindprince <gi...@git.apache.org> on 2015/12/02 01:22:49 UTC
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
GitHub user mindprince opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/499
Minor improvement in RemoteInterpreter.java
No need to call `getInterpreterProcess()` again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mindprince/incubator-zeppelin remote-interpreter-improvement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #499
----
commit 7d2744c4c250193a93bfc79505976b5be5cf00fa
Author: Rohit Agarwal <ro...@qubole.com>
Date: 2015-12-02T00:21:04Z
No need to call getInterpreterProcess() again.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by mindprince <gi...@git.apache.org>.
Github user mindprince commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/499#issuecomment-161173827
The Travis CI failure above. logs: https://s3.amazonaws.com/archive.travis-ci.org/jobs/94297136/log.txt
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by mindprince <gi...@git.apache.org>.
Github user mindprince commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/499#issuecomment-161160055
I am not sure if I got the correct error from the CI's log (it is huge) but it looks to be the following
```
Results :
Tests in error:
ZeppelinIT.testAngularDisplay:242 » ElementNotVisible Element is not currently...
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
```
which is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/499#issuecomment-162270322
Could you please close and reopen this PR for triggering CI again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by mindprince <gi...@git.apache.org>.
Github user mindprince commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/499#issuecomment-162259984
Let's merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/499#issuecomment-161412481
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/499#issuecomment-161160421
Which CI failure seems unrelated. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by mindprince <gi...@git.apache.org>.
Github user mindprince closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by mindprince <gi...@git.apache.org>.
GitHub user mindprince reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/499
Minor improvement in RemoteInterpreter.java
No need to call `getInterpreterProcess()` again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mindprince/incubator-zeppelin remote-interpreter-improvement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/499.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #499
----
commit 7d2744c4c250193a93bfc79505976b5be5cf00fa
Author: Rohit Agarwal <ro...@qubole.com>
Date: 2015-12-02T00:21:04Z
No need to call getInterpreterProcess() again.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/499#issuecomment-162270298
Merging if there isn't discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Minor improvement in RemoteInterp...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/499
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---