You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by phongphan <gi...@git.apache.org> on 2015/10/29 18:13:12 UTC

[GitHub] thrift pull request: THRIFT-2779: Always write unescaped JSON unic...

GitHub user phongphan opened a pull request:

    https://github.com/apache/thrift/pull/666

    THRIFT-2779: Always write unescaped JSON unicode string.

    Hi
    
    This should fixed THRIFT-2779 by always write JSON string unescaped. When running with PHP > 5.4, it will use `JSON_UNESCAPED_UNICODE` flag and use `mb_convert_encoding` when running older version of PHP.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phongphan/thrift THRIFT-2779

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #666
    
----
commit b78bdf7622cce8970f219a641304d04ee273325d
Author: Phongphan Phuttha <ph...@acm.org>
Date:   2015-10-29T17:00:10Z

    THRIFT-2779: Always write unescaped JSON unicode string.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2779: Always write unescaped JSON unic...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/666


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---