[GitHub] pnowojski commented on issue #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL

[GitBox <gi...@apache.org>]

pnowojski commented on issue #6736: [FLINK-10398][table] Add Tanh math function supported in Table API and SQL
URL: https://github.com/apache/flink/pull/6736#issuecomment-431023636
 
 
   Ok, LGTM, I would like to merge it before 1.7 feature freeze and I didn't see objections from @xccui so I assume that he is ok with this. (If not feel free to open some follow up issue - documentation we can always change later, after the feature freeze).
   
   On a side note, I do not understand while why we have this inconsistency between SQL and Table API. Why for Table API we are using capital case:
   ```
   <p>Returns the tangent of <i>NUMERIC</i>.</p>
   ```
   and for sql lower case:
   ```
   <p>Returns the tangent of <i>numeric</i>.</p>
   ```
   This seems strange... but I won't dive into this right now.
   
   
   Again thanks for contribution @yanghua 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services