You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/06/30 12:56:26 UTC
[commons-statistics] branch master updated (880304d -> 7673b13)
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git.
from 880304d PMD fix: avoid literals in conditional statement
new 2d7a487 Remove public modifiers for test fixtures.
new 7673b13 Add assertions to test cases.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../distribution/AbstractContinuousDistributionTest.java | 2 +-
.../distribution/AbstractDiscreteDistributionTest.java | 2 +-
.../statistics/distribution/BetaDistributionTest.java | 2 +-
.../statistics/distribution/BinomialDistributionTest.java | 4 ++--
.../statistics/distribution/CauchyDistributionTest.java | 4 ++--
.../statistics/distribution/ChiSquaredDistributionTest.java | 4 ++--
.../distribution/ConstantContinuousDistributionTest.java | 6 +++---
.../distribution/ContinuousDistributionAbstractTest.java | 4 ++--
.../statistics/distribution/ContinuousDistributionTest.java | 2 +-
.../distribution/DiscreteDistributionAbstractTest.java | 4 ++--
.../statistics/distribution/DiscreteDistributionTest.java | 2 +-
.../statistics/distribution/ExponentialDistributionTest.java | 4 ++--
.../commons/statistics/distribution/FDistributionTest.java | 4 ++--
.../statistics/distribution/GammaDistributionTest.java | 4 ++--
.../statistics/distribution/GeometricDistributionTest.java | 4 ++--
.../statistics/distribution/GumbelDistributionTest.java | 2 +-
.../distribution/HypergeometricDistributionTest.java | 4 ++--
.../statistics/distribution/LaplaceDistributionTest.java | 2 +-
.../statistics/distribution/LevyDistributionTest.java | 2 +-
.../statistics/distribution/LogNormalDistributionTest.java | 4 ++--
.../statistics/distribution/LogisticsDistributionTest.java | 2 +-
.../statistics/distribution/NakagamiDistributionTest.java | 2 +-
.../statistics/distribution/NormalDistributionTest.java | 4 ++--
.../statistics/distribution/ParetoDistributionTest.java | 4 ++--
.../statistics/distribution/PascalDistributionTest.java | 4 ++--
.../statistics/distribution/PoissonDistributionTest.java | 4 ++--
.../commons/statistics/distribution/TDistributionTest.java | 12 +++++++-----
.../statistics/distribution/TriangularDistributionTest.java | 4 ++--
.../distribution/UniformContinuousDistributionTest.java | 4 ++--
.../distribution/UniformDiscreteDistributionTest.java | 6 +++---
.../statistics/distribution/WeibullDistributionTest.java | 2 +-
.../statistics/distribution/ZipfDistributionTest.java | 4 ++--
32 files changed, 60 insertions(+), 58 deletions(-)
[commons-statistics] 01/02: Remove public modifiers for test
fixtures.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 2d7a487caf515dac7aee0605c80aacca9ebcc741
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Jun 30 13:53:04 2020 +0100
Remove public modifiers for test fixtures.
---
.../statistics/distribution/AbstractContinuousDistributionTest.java | 2 +-
.../statistics/distribution/AbstractDiscreteDistributionTest.java | 2 +-
.../commons/statistics/distribution/BetaDistributionTest.java | 2 +-
.../commons/statistics/distribution/BinomialDistributionTest.java | 4 ++--
.../commons/statistics/distribution/CauchyDistributionTest.java | 4 ++--
.../commons/statistics/distribution/ChiSquaredDistributionTest.java | 4 ++--
.../statistics/distribution/ConstantContinuousDistributionTest.java | 6 +++---
.../statistics/distribution/ContinuousDistributionAbstractTest.java | 4 ++--
.../commons/statistics/distribution/ContinuousDistributionTest.java | 2 +-
.../statistics/distribution/DiscreteDistributionAbstractTest.java | 4 ++--
.../commons/statistics/distribution/DiscreteDistributionTest.java | 2 +-
.../statistics/distribution/ExponentialDistributionTest.java | 4 ++--
.../apache/commons/statistics/distribution/FDistributionTest.java | 4 ++--
.../commons/statistics/distribution/GammaDistributionTest.java | 4 ++--
.../commons/statistics/distribution/GeometricDistributionTest.java | 4 ++--
.../commons/statistics/distribution/GumbelDistributionTest.java | 2 +-
.../statistics/distribution/HypergeometricDistributionTest.java | 4 ++--
.../commons/statistics/distribution/LaplaceDistributionTest.java | 2 +-
.../commons/statistics/distribution/LevyDistributionTest.java | 2 +-
.../commons/statistics/distribution/LogNormalDistributionTest.java | 4 ++--
.../commons/statistics/distribution/LogisticsDistributionTest.java | 2 +-
.../commons/statistics/distribution/NakagamiDistributionTest.java | 2 +-
.../commons/statistics/distribution/NormalDistributionTest.java | 4 ++--
.../commons/statistics/distribution/ParetoDistributionTest.java | 4 ++--
.../commons/statistics/distribution/PascalDistributionTest.java | 4 ++--
.../commons/statistics/distribution/PoissonDistributionTest.java | 4 ++--
.../apache/commons/statistics/distribution/TDistributionTest.java | 4 ++--
.../commons/statistics/distribution/TriangularDistributionTest.java | 4 ++--
.../statistics/distribution/UniformContinuousDistributionTest.java | 4 ++--
.../statistics/distribution/UniformDiscreteDistributionTest.java | 4 ++--
.../commons/statistics/distribution/WeibullDistributionTest.java | 2 +-
.../commons/statistics/distribution/ZipfDistributionTest.java | 4 ++--
32 files changed, 54 insertions(+), 54 deletions(-)
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
index d44ca18..2c6d852 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractContinuousDistributionTest.java
@@ -23,7 +23,7 @@ import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
/** Various tests related to MATH-699. */
-public class AbstractContinuousDistributionTest {
+class AbstractContinuousDistributionTest {
@Test
void testContinuous() {
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractDiscreteDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractDiscreteDistributionTest.java
index 44358c8..39d45dc 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractDiscreteDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/AbstractDiscreteDistributionTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for AbstractDiscreteDistribution default implementations.
*/
-public class AbstractDiscreteDistributionTest {
+class AbstractDiscreteDistributionTest {
protected final DiceDistribution diceDistribution = new DiceDistribution();
protected final double p = diceDistribution.probability(1);
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BetaDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BetaDistributionTest.java
index 71c9ace..8e2ce43 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BetaDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BetaDistributionTest.java
@@ -25,7 +25,7 @@ import org.apache.commons.math3.stat.inference.GTest;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class BetaDistributionTest {
+class BetaDistributionTest {
static final double[] ALPHA_BETAS = {0.1, 1, 10, 100, 1000};
static final double EPSILON = StatUtils.min(ALPHA_BETAS);
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
index 8ad6e36..2b01f20 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/BinomialDistributionTest.java
@@ -24,12 +24,12 @@ import org.junit.jupiter.api.Test;
* Test cases for BinomialDistribution. Extends DiscreteDistributionAbstractTest.
* See class javadoc for DiscreteDistributionAbstractTest for details.
*/
-public class BinomialDistributionTest extends DiscreteDistributionAbstractTest {
+class BinomialDistributionTest extends DiscreteDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-12);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java
index 3a17d78..4d07667 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/CauchyDistributionTest.java
@@ -26,14 +26,14 @@ import org.junit.jupiter.api.Test;
* Extends ContinuousDistributionAbstractTest. See class javadoc for
* ContinuousDistributionAbstractTest for details.
*/
-public class CauchyDistributionTest extends ContinuousDistributionAbstractTest {
+class CauchyDistributionTest extends ContinuousDistributionAbstractTest {
private static final double DEFAULT_TOLERANCE = 1e-7;
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(DEFAULT_TOLERANCE);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ChiSquaredDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ChiSquaredDistributionTest.java
index aec0eb0..921129b 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ChiSquaredDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ChiSquaredDistributionTest.java
@@ -26,12 +26,12 @@ import org.junit.jupiter.api.Test;
*
* @see ContinuousDistributionAbstractTest
*/
-public class ChiSquaredDistributionTest extends ContinuousDistributionAbstractTest {
+class ChiSquaredDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-9);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java
index 65d7670..6da7840 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ConstantContinuousDistributionTest.java
@@ -24,12 +24,12 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for ConstantContinuousDistribution.
*/
-public class ConstantContinuousDistributionTest extends ContinuousDistributionAbstractTest {
+class ConstantContinuousDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(0);
}
@@ -82,7 +82,7 @@ public class ConstantContinuousDistributionTest extends ContinuousDistributionAb
@Test
@Override
- public void testSampler() {
+ void testSampler() {
final double value = 12.345;
final ContinuousDistribution.Sampler sampler = new ConstantContinuousDistribution(value).createSampler(null);
for (int i = 0; i < 10; i++) {
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
index 666bdbc..201ecfd 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionAbstractTest.java
@@ -134,7 +134,7 @@ public abstract class ContinuousDistributionAbstractTest {
* to alter the defaults.
*/
@BeforeEach
- public void setUp() {
+ void setUp() {
distribution = makeDistribution();
cumulativeTestPoints = makeCumulativeTestPoints();
cumulativeTestValues = makeCumulativeTestValues();
@@ -148,7 +148,7 @@ public abstract class ContinuousDistributionAbstractTest {
* Cleans up test instance data
*/
@AfterEach
- public void tearDown() {
+ void tearDown() {
distribution = null;
cumulativeTestPoints = null;
cumulativeTestValues = null;
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionTest.java
index c1136e8..da3b3aa 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ContinuousDistributionTest.java
@@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test;
/**
* Test default implementations in the {@link ContinuousDistribution} interface.
*/
-public class ContinuousDistributionTest {
+class ContinuousDistributionTest {
/**
* Test the default interface methods.
*/
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
index 2281444..6315593 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionAbstractTest.java
@@ -117,7 +117,7 @@ public abstract class DiscreteDistributionAbstractTest {
* Setup sets all test instance data to default values
*/
@BeforeEach
- public void setUp() {
+ void setUp() {
distribution = makeDistribution();
densityTestPoints = makeDensityTestPoints();
densityTestValues = makeDensityTestValues();
@@ -132,7 +132,7 @@ public abstract class DiscreteDistributionAbstractTest {
* Cleans up test instance data
*/
@AfterEach
- public void tearDown() {
+ void tearDown() {
distribution = null;
densityTestPoints = null;
densityTestValues = null;
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionTest.java
index 7ad409e..aa4960a 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/DiscreteDistributionTest.java
@@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test;
/**
* Test default implementations in the {@link DiscreteDistribution} interface.
*/
-public class DiscreteDistributionTest {
+class DiscreteDistributionTest {
/**
* Test the default interface methods.
*/
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java
index de9e758..c62f638 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ExponentialDistributionTest.java
@@ -26,12 +26,12 @@ import org.junit.jupiter.api.Test;
* Extends ContinuousDistributionAbstractTest. See class javadoc for
* ContinuousDistributionAbstractTest for details.
*/
-public class ExponentialDistributionTest extends ContinuousDistributionAbstractTest {
+class ExponentialDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-9);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/FDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/FDistributionTest.java
index b303bce..ae87559 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/FDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/FDistributionTest.java
@@ -25,12 +25,12 @@ import org.junit.jupiter.api.Test;
* Extends ContinuousDistributionAbstractTest. See class javadoc for
* ContinuousDistributionAbstractTest for details.
*/
-public class FDistributionTest extends ContinuousDistributionAbstractTest {
+class FDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-9);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java
index 2ebf952..11e3b93 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GammaDistributionTest.java
@@ -33,14 +33,14 @@ import org.junit.jupiter.api.Test;
* Extends ContinuousDistributionAbstractTest. See class javadoc for
* ContinuousDistributionAbstractTest for details.
*/
-public class GammaDistributionTest extends ContinuousDistributionAbstractTest {
+class GammaDistributionTest extends ContinuousDistributionAbstractTest {
private static final double HALF_LOG_2_PI = 0.5 * Math.log(2.0 * Math.PI);
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-9);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java
index 129feed..918b45a 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GeometricDistributionTest.java
@@ -24,12 +24,12 @@ import org.junit.jupiter.api.Test;
* Test cases for GeometricDistribution.
* See class javadoc for DiscreteDistributionAbstractTest for details.
*/
-public class GeometricDistributionTest extends DiscreteDistributionAbstractTest {
+class GeometricDistributionTest extends DiscreteDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-12);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java
index abc0612..e90fde0 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/GumbelDistributionTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for GumbelDistribution.
*/
-public class GumbelDistributionTest extends ContinuousDistributionAbstractTest {
+class GumbelDistributionTest extends ContinuousDistributionAbstractTest {
//-------------- Implementations for abstract methods ----------------------
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java
index a142d2c..a662ea2 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/HypergeometricDistributionTest.java
@@ -28,12 +28,12 @@ import org.junit.jupiter.api.Test;
* Extends DiscreteDistributionAbstractTest. See class javadoc for
* DiscreteDistributionAbstractTest for details.
*/
-public class HypergeometricDistributionTest extends DiscreteDistributionAbstractTest {
+class HypergeometricDistributionTest extends DiscreteDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-12);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java
index 5cf85e5..ce066b5 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LaplaceDistributionTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for LaplaceDistribution.
*/
-public class LaplaceDistributionTest extends ContinuousDistributionAbstractTest {
+class LaplaceDistributionTest extends ContinuousDistributionAbstractTest {
//-------------- Implementations for abstract methods ----------------------
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java
index a1fa752..977b4dd 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LevyDistributionTest.java
@@ -19,7 +19,7 @@ package org.apache.commons.statistics.distribution;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
-public class LevyDistributionTest extends ContinuousDistributionAbstractTest {
+class LevyDistributionTest extends ContinuousDistributionAbstractTest {
//-------------- Implementations for abstract methods ----------------------
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogNormalDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogNormalDistributionTest.java
index c19f33d..f5c5cb6 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogNormalDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogNormalDistributionTest.java
@@ -26,12 +26,12 @@ import org.junit.jupiter.api.Test;
* {@link ContinuousDistributionAbstractTest}. See class javadoc of that class
* for details.
*/
-public class LogNormalDistributionTest extends ContinuousDistributionAbstractTest {
+class LogNormalDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-7);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java
index 1444433..e334b48 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/LogisticsDistributionTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for LogisticsDistribution.
*/
-public class LogisticsDistributionTest extends ContinuousDistributionAbstractTest {
+class LogisticsDistributionTest extends ContinuousDistributionAbstractTest {
//-------------- Implementations for abstract methods ----------------------
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
index 4a5f151..d9d5934 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NakagamiDistributionTest.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
/**
* Test cases for NakagamiDistribution.
*/
-public class NakagamiDistributionTest extends ContinuousDistributionAbstractTest {
+class NakagamiDistributionTest extends ContinuousDistributionAbstractTest {
//-------------- Implementations for abstract methods ----------------------
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java
index 5b37c29..0beae1e 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/NormalDistributionTest.java
@@ -26,14 +26,14 @@ import org.junit.jupiter.api.Test;
* {@link ContinuousDistributionAbstractTest}. See class javadoc of that class
* for details.
*/
-public class NormalDistributionTest extends ContinuousDistributionAbstractTest {
+class NormalDistributionTest extends ContinuousDistributionAbstractTest {
private static final double DEFAULT_TOLERANCE = 1e-7;
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(DEFAULT_TOLERANCE);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ParetoDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ParetoDistributionTest.java
index 2074c42..73b13d3 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ParetoDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ParetoDistributionTest.java
@@ -25,12 +25,12 @@ import org.junit.jupiter.api.Test;
* Test cases for {@link ParetoDistribution}.
* Extends {@link ContinuousDistributionAbstractTest}. See class javadoc of that class for details.
*/
-public class ParetoDistributionTest extends ContinuousDistributionAbstractTest {
+class ParetoDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-7);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PascalDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PascalDistributionTest.java
index 446a7ef..3fbe13c 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PascalDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PascalDistributionTest.java
@@ -25,14 +25,14 @@ import org.junit.jupiter.api.Test;
* Extends DiscreteDistributionAbstractTest. See class javadoc for
* DiscreteDistributionAbstractTest for details.
*/
-public class PascalDistributionTest extends DiscreteDistributionAbstractTest {
+class PascalDistributionTest extends DiscreteDistributionAbstractTest {
private static final double DEFAULT_TOLERANCE = 1e-7;
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(DEFAULT_TOLERANCE);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PoissonDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PoissonDistributionTest.java
index a2351ad..8a71a8a 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PoissonDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/PoissonDistributionTest.java
@@ -23,7 +23,7 @@ import org.junit.jupiter.api.Test;
/**
* <code>PoissonDistributionTest</code>
*/
-public class PoissonDistributionTest extends DiscreteDistributionAbstractTest {
+class PoissonDistributionTest extends DiscreteDistributionAbstractTest {
/**
* Poisson parameter value for the test distribution.
@@ -33,7 +33,7 @@ public class PoissonDistributionTest extends DiscreteDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-12);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
index 6953672..dba7dc9 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
@@ -24,12 +24,12 @@ import org.junit.jupiter.api.Test;
* Extends ContinuousDistributionAbstractTest. See class javadoc for
* ContinuousDistributionAbstractTest for details.
*/
-public class TDistributionTest extends ContinuousDistributionAbstractTest {
+class TDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-9);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TriangularDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TriangularDistributionTest.java
index c1daab8..f7c9db0 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TriangularDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TriangularDistributionTest.java
@@ -25,12 +25,12 @@ import org.junit.jupiter.api.Test;
* Test cases for {@link TriangularDistribution}. See class javadoc for
* {@link ContinuousDistributionAbstractTest} for further details.
*/
-public class TriangularDistributionTest extends ContinuousDistributionAbstractTest {
+class TriangularDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-4);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformContinuousDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformContinuousDistributionTest.java
index 5864513..3938421 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformContinuousDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformContinuousDistributionTest.java
@@ -25,12 +25,12 @@ import org.junit.jupiter.api.Test;
* Test cases for UniformContinuousDistribution. See class javadoc for
* {@link ContinuousDistributionAbstractTest} for further details.
*/
-public class UniformContinuousDistributionTest extends ContinuousDistributionAbstractTest {
+class UniformContinuousDistributionTest extends ContinuousDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-4);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java
index 242a7d5..d0fcd27 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java
@@ -26,12 +26,12 @@ import org.apache.commons.numbers.core.Precision;
* Test cases for UniformDiscreteDistribution. See class javadoc for
* {@link DiscreteDistributionAbstractTest} for further details.
*/
-public class UniformDiscreteDistributionTest extends DiscreteDistributionAbstractTest {
+class UniformDiscreteDistributionTest extends DiscreteDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-9);
}
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/WeibullDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/WeibullDistributionTest.java
index 0f20e12..02df59a 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/WeibullDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/WeibullDistributionTest.java
@@ -26,7 +26,7 @@ import org.junit.jupiter.api.Test;
* Extends ContinuousDistributionAbstractTest. See class javadoc for
* ContinuousDistributionAbstractTest for details.
*/
-public class WeibullDistributionTest extends ContinuousDistributionAbstractTest {
+class WeibullDistributionTest extends ContinuousDistributionAbstractTest {
//-------------- Implementations for abstract methods ----------------------
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ZipfDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ZipfDistributionTest.java
index 730d50e..3804048 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ZipfDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/ZipfDistributionTest.java
@@ -27,12 +27,12 @@ import org.junit.jupiter.api.Test;
* Extends DiscreteDistributionAbstractTest.
* See class javadoc for DiscreteDistributionAbstractTest for details.
*/
-public class ZipfDistributionTest extends DiscreteDistributionAbstractTest {
+class ZipfDistributionTest extends DiscreteDistributionAbstractTest {
//---------------------- Override tolerance --------------------------------
@BeforeEach
- public void customSetUp() {
+ void customSetUp() {
setTolerance(1e-12);
}
[commons-statistics] 02/02: Add assertions to test cases.
Posted by ah...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-statistics.git
commit 7673b134fdd56ececc1eed8329d03567885c657a
Author: aherbert <ah...@apache.org>
AuthorDate: Tue Jun 30 13:56:21 2020 +0100
Add assertions to test cases.
---
.../apache/commons/statistics/distribution/TDistributionTest.java | 8 +++++---
.../statistics/distribution/UniformDiscreteDistributionTest.java | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
index dba7dc9..36ec1a8 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/TDistributionTest.java
@@ -71,9 +71,11 @@ class TDistributionTest extends ContinuousDistributionAbstractTest {
*/
@Test
void testCumulativeProbabilityAgainstStackOverflow() {
- final TDistribution td = new TDistribution(5.);
- td.cumulativeProbability(.1);
- td.cumulativeProbability(.01);
+ Assertions.assertDoesNotThrow(() -> {
+ final TDistribution td = new TDistribution(5.);
+ td.cumulativeProbability(.1);
+ td.cumulativeProbability(.01);
+ });
}
@Test
diff --git a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java
index d0fcd27..2cc2feb 100644
--- a/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java
+++ b/commons-statistics-distribution/src/test/java/org/apache/commons/statistics/distribution/UniformDiscreteDistributionTest.java
@@ -108,7 +108,7 @@ class UniformDiscreteDistributionTest extends DiscreteDistributionAbstractTest {
@Test
void testPreconditionUpperBoundInclusive2() {
// Degenerate case is allowed.
- new UniformDiscreteDistribution(0, 0);
+ Assertions.assertDoesNotThrow(() -> new UniformDiscreteDistribution(0, 0));
}
// MATH-1396