You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/10/13 21:55:27 UTC

[GitHub] [pinot] agavra commented on a diff in pull request #9578: add version information to JMX metrics & component logs

agavra commented on code in PR #9578:
URL: https://github.com/apache/pinot/pull/9578#discussion_r995156466


##########
pinot-common/pom.xml:
##########
@@ -36,6 +36,12 @@
   </properties>
 
   <build>
+    <resources>
+      <resource>
+        <directory>src/main/resources</directory>
+        <filtering>true</filtering>
+      </resource>
+    </resources>

Review Comment:
   filtering (see the javadoc of `PinotVersion`) is what allows maven to understand that it should replace `${project.version}` with the actual version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org