You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Mark Weitzel (JIRA)" <ji...@apache.org> on 2011/01/28 03:06:44 UTC
[jira] Created: (SHINDIG-1494) ProxyServlet special case for Flash
files is not always effective
ProxyServlet special case for Flash files is not always effective
-----------------------------------------------------------------
Key: SHINDIG-1494
URL: https://issues.apache.org/jira/browse/SHINDIG-1494
Project: Shindig
Issue Type: Bug
Affects Versions: 2.0.2, 3.0.0
Reporter: Mark Weitzel
The ProxyServlet.setResponseContentHeaders() method has special logic that attempts to avoid adding a "Content-Disposition" header when the content type is "application/x-shockwave-flash". This is because adding this header causes problems with version 10 of the Flash plugin (flash apps fail to load).
Unfortunately, though, the check is a case-insensitive exact match against "application/x-shockwave-flash", which fails to match correctly when the incoming content type is "application/x-shockwave-flash;charset=utf-8" (which it will be because the charset parameter is added elsewhere).
Patches to perform a correct test are attached for both Shindig trunk and the 2.0.x branches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1494) ProxyServlet special case for Flash
files is not always effective
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner resolved SHINDIG-1494.
-----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Thanks, I applied to trunk a modified version that uses StringUtils case insensitive startwith and also added a test.
> ProxyServlet special case for Flash files is not always effective
> -----------------------------------------------------------------
>
> Key: SHINDIG-1494
> URL: https://issues.apache.org/jira/browse/SHINDIG-1494
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Mark Weitzel
> Fix For: 3.0.0
>
> Attachments: ProxyHandler-2.0.x.patch, ProxyHandlerTrunk.patch
>
>
> The ProxyServlet.setResponseContentHeaders() method has special logic that attempts to avoid adding a "Content-Disposition" header when the content type is "application/x-shockwave-flash". This is because adding this header causes problems with version 10 of the Flash plugin (flash apps fail to load).
> Unfortunately, though, the check is a case-insensitive exact match against "application/x-shockwave-flash", which fails to match correctly when the incoming content type is "application/x-shockwave-flash;charset=utf-8" (which it will be because the charset parameter is added elsewhere).
> Patches to perform a correct test are attached for both Shindig trunk and the 2.0.x branches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Closed] (SHINDIG-1494) ProxyServlet special case for Flash
files is not always effective
Posted by "Paul Lindner (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Paul Lindner closed SHINDIG-1494.
---------------------------------
part of 2.5.0-beta1 release.
> ProxyServlet special case for Flash files is not always effective
> -----------------------------------------------------------------
>
> Key: SHINDIG-1494
> URL: https://issues.apache.org/jira/browse/SHINDIG-1494
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.0.2, 2.5.0-beta1
> Reporter: Mark Weitzel
> Fix For: 2.5.0-beta1
>
> Attachments: ProxyHandler-2.0.x.patch, ProxyHandlerTrunk.patch
>
>
> The ProxyServlet.setResponseContentHeaders() method has special logic that attempts to avoid adding a "Content-Disposition" header when the content type is "application/x-shockwave-flash". This is because adding this header causes problems with version 10 of the Flash plugin (flash apps fail to load).
> Unfortunately, though, the check is a case-insensitive exact match against "application/x-shockwave-flash", which fails to match correctly when the incoming content type is "application/x-shockwave-flash;charset=utf-8" (which it will be because the charset parameter is added elsewhere).
> Patches to perform a correct test are attached for both Shindig trunk and the 2.0.x branches.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (SHINDIG-1494) ProxyServlet special case for Flash
files is not always effective
Posted by "Mark Weitzel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Weitzel updated SHINDIG-1494:
----------------------------------
Attachment: ProxyHandler-2.0.x.patch
ProxyHandlerTrunk.patch
> ProxyServlet special case for Flash files is not always effective
> -----------------------------------------------------------------
>
> Key: SHINDIG-1494
> URL: https://issues.apache.org/jira/browse/SHINDIG-1494
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.0.2, 3.0.0
> Reporter: Mark Weitzel
> Attachments: ProxyHandler-2.0.x.patch, ProxyHandlerTrunk.patch
>
>
> The ProxyServlet.setResponseContentHeaders() method has special logic that attempts to avoid adding a "Content-Disposition" header when the content type is "application/x-shockwave-flash". This is because adding this header causes problems with version 10 of the Flash plugin (flash apps fail to load).
> Unfortunately, though, the check is a case-insensitive exact match against "application/x-shockwave-flash", which fails to match correctly when the incoming content type is "application/x-shockwave-flash;charset=utf-8" (which it will be because the charset parameter is added elsewhere).
> Patches to perform a correct test are attached for both Shindig trunk and the 2.0.x branches.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.