You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Harsh J (JIRA)" <ji...@apache.org> on 2012/04/22 09:03:32 UTC
[jira] [Created] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Harsh J created MAPREDUCE-4175:
----------------------------------
Summary: Clean up hadoop-mapreduce-client-core
Key: MAPREDUCE-4175
URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
Project: Hadoop Map/Reduce
Issue Type: Sub-task
Components: build
Affects Versions: trunk
Reporter: Harsh J
Assignee: Harsh J
Priority: Minor
Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259038#comment-13259038 ]
Hadoop QA commented on MAPREDUCE-4175:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523670/0003-MapReduce-Client-Core-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified test files.
-1 javadoc. The javadoc tool appears to have generated 4 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.TestContainerManagerSecurity
org.apache.hadoop.yarn.server.resourcemanager.security.TestApplicationTokens
org.apache.hadoop.yarn.server.resourcemanager.TestClientRMService
org.apache.hadoop.yarn.server.resourcemanager.resourcetracker.TestNMExpiry
org.apache.hadoop.yarn.server.resourcemanager.TestAMAuthorization
org.apache.hadoop.yarn.server.resourcemanager.TestApplicationACLs
org.apache.hadoop.mapreduce.lib.output.TestFileOutputCommitter
org.apache.hadoop.mapred.TestClientRedirect
org.apache.hadoop.mapreduce.security.TestJHSSecurity
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2271//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2271//console
This message is automatically generated.
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4175:
-------------------------------
Attachment: 0003-MapReduce-Client-Core-Cleanup.patch
Almost a complete clean up. I didn't touch JobConf (There are too many changes here, I'll do it later as another subtask), JobClient (Couldn't yet figure out how to switch to Token#renew from existing deprecated calls) and a couple of non-inheritance warnings in some client API packages that need a ticket of their own. I'll create their tickets after this is reviewed (when I revisit).
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4175:
-------------------------------
Status: Patch Available (was: Open)
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4175:
-------------------------------
Status: Open (was: Patch Available)
Cancelled patch to address the javadocs and other issues. Will post an update soon.
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch, 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259265#comment-13259265 ]
Harsh J commented on MAPREDUCE-4175:
------------------------------------
(Rest of the failures are not related to patch, and are appearing intermittently over all tests, save for org.apache.hadoop.yarn.server.TestContainerManagerSecurity which is appearing always)
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch, 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J resolved MAPREDUCE-4175.
--------------------------------
Resolution: Won't Fix
Patches were too broad and have gone stale. Will address these forms of issue over separate, smaller and more divided JIRAs in future.
Closing out parent JIRA MAPREDUCE-4172, and hence closing out this.
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch, 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Harsh J updated MAPREDUCE-4175:
-------------------------------
Attachment: 0003-MapReduce-Client-Core-Cleanup.patch
The org.apache.hadoop.mapreduce.lib.output.TestFileOutputCommitter failure was cause of MapFileOutputFormat changes. I ported the MapFile Writer API to the new Options format but it had a small issue in it (key class matched the value class).
This issue has been resolved in this new patch.
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch, 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-4175) Clean up
hadoop-mapreduce-client-core
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-4175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13265572#comment-13265572 ]
Hadoop QA commented on MAPREDUCE-4175:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12523719/0003-MapReduce-Client-Core-Cleanup.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified test files.
-1 javadoc. The javadoc tool appears to have generated 20 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2339//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2339//console
This message is automatically generated.
> Clean up hadoop-mapreduce-client-core
> -------------------------------------
>
> Key: MAPREDUCE-4175
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4175
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: build
> Affects Versions: trunk
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Attachments: 0003-MapReduce-Client-Core-Cleanup.patch, 0003-MapReduce-Client-Core-Cleanup.patch
>
>
> Clean up a bunch of existing javac warnings in hadoop-mapreduce-client-core module.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira