You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "betodealmeida (via GitHub)" <gi...@apache.org> on 2025/09/22 16:33:45 UTC
[PR] fix: docker-compose file and superset-core [superset]
betodealmeida opened a new pull request, #35235:
URL: https://github.com/apache/superset/pull/35235
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
`docker compose up` stopped working because of the introduction of `superset-core`.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #35235:
URL: https://github.com/apache/superset/pull/35235#discussion_r2369432922
##########
docker/docker-bootstrap.sh:
##########
@@ -18,9 +18,16 @@
set -eo pipefail
-# Make python interactive
+# Install critical dependencies first in dev mode to fix volume mount issues
if [ "$DEV_MODE" == "true" ]; then
if [ "$(whoami)" = "root" ] && command -v uv > /dev/null 2>&1; then
+ echo "Installing critical dependencies for dev mode..."
+ # Install pydantic first as it's needed for imports
+ uv pip install --no-cache-dir "pydantic>=2.8.0"
+ echo "Installing base requirements"
+ uv pip install -r /app/requirements/base.txt
Review Comment:
Should we do development.txt here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #35235:
URL: https://github.com/apache/superset/pull/35235#issuecomment-3324945712
@betodealmeida It seems there's an error yet: https://github.com/apache/superset/actions/runs/17953994393/job/51060324919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #35235:
URL: https://github.com/apache/superset/pull/35235#discussion_r2369424200
##########
docker/docker-bootstrap.sh:
##########
@@ -18,9 +18,16 @@
set -eo pipefail
-# Make python interactive
+# Install critical dependencies first in dev mode to fix volume mount issues
if [ "$DEV_MODE" == "true" ]; then
if [ "$(whoami)" = "root" ] && command -v uv > /dev/null 2>&1; then
+ echo "Installing critical dependencies for dev mode..."
+ # Install pydantic first as it's needed for imports
+ uv pip install --no-cache-dir "pydantic>=2.8.0"
Review Comment:
This should be in requirements/development.txt already (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #35235:
URL: https://github.com/apache/superset/pull/35235#discussion_r2369686078
##########
docker/docker-bootstrap.sh:
##########
@@ -18,9 +18,16 @@
set -eo pipefail
-# Make python interactive
+# Install critical dependencies first in dev mode to fix volume mount issues
if [ "$DEV_MODE" == "true" ]; then
if [ "$(whoami)" = "root" ] && command -v uv > /dev/null 2>&1; then
+ echo "Installing critical dependencies for dev mode..."
+ # Install pydantic first as it's needed for imports
+ uv pip install --no-cache-dir "pydantic>=2.8.0"
+ echo "Installing base requirements"
+ uv pip install -r /app/requirements/base.txt
Review Comment:
@mistercrunch I think there are folks that use it for production even if not recommended 🤷🏼♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "mistercrunch (via GitHub)" <gi...@apache.org>.
mistercrunch commented on code in PR #35235:
URL: https://github.com/apache/superset/pull/35235#discussion_r2369456716
##########
docker/docker-bootstrap.sh:
##########
@@ -18,9 +18,16 @@
set -eo pipefail
-# Make python interactive
+# Install critical dependencies first in dev mode to fix volume mount issues
if [ "$DEV_MODE" == "true" ]; then
if [ "$(whoami)" = "root" ] && command -v uv > /dev/null 2>&1; then
+ echo "Installing critical dependencies for dev mode..."
+ # Install pydantic first as it's needed for imports
+ uv pip install --no-cache-dir "pydantic>=2.8.0"
+ echo "Installing base requirements"
+ uv pip install -r /app/requirements/base.txt
+ echo "Reinstalling superset-core in editable mode"
+ uv pip install -e /app/superset-core
Review Comment:
wondering what this is about (?) I have to admit I don't understand the new structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "betodealmeida (via GitHub)" <gi...@apache.org>.
betodealmeida commented on PR #35235:
URL: https://github.com/apache/superset/pull/35235#issuecomment-3324965782
> @betodealmeida It seems there's an error yet: https://github.com/apache/superset/actions/runs/17953994393/job/51060324919
I'll fix that in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #35235:
URL: https://github.com/apache/superset/pull/35235#issuecomment-3320070658
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment `/korbit-review`.
> Your admin can change your review schedule in the [Korbit Console](https://app.korbit.ai/settings)
[](fbf13361-17e5-4bf5-bc56-4e7d24409a0b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #35235:
URL: https://github.com/apache/superset/pull/35235#discussion_r2369699024
##########
docker/docker-entrypoint.sh:
##########
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -eo pipefail
+
+# In dev mode with volume mounts, we need to ensure dependencies are installed
+# BEFORE any Python code runs, as volumes override the image's site-packages
+if [ "$DEV_MODE" == "true" ]; then
+ if [ "$(whoami)" = "root" ] && command -v uv > /dev/null 2>&1; then
+ echo "Dev mode detected. Ensuring critical dependencies are installed..."
+ # Quick install of critical packages that are needed for imports
+ uv pip install --no-cache-dir "pydantic>=2.8.0" "marshmallow-union" 2>/dev/null || true
+ fi
+fi
+
+# Now run the actual bootstrap script
+exec "$@"
Review Comment:
@betodealmeida You need a blank line at the end here to fix CI 😉
```suggestion
exec "$@"
```
##########
docker/docker-entrypoint.sh:
##########
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+set -eo pipefail
+
+# In dev mode with volume mounts, we need to ensure dependencies are installed
+# BEFORE any Python code runs, as volumes override the image's site-packages
+if [ "$DEV_MODE" == "true" ]; then
+ if [ "$(whoami)" = "root" ] && command -v uv > /dev/null 2>&1; then
+ echo "Dev mode detected. Ensuring critical dependencies are installed..."
+ # Quick install of critical packages that are needed for imports
+ uv pip install --no-cache-dir "pydantic>=2.8.0" "marshmallow-union" 2>/dev/null || true
+ fi
+fi
+
+# Now run the actual bootstrap script
+exec "$@"
Review Comment:
@betodealmeida You need a blank line at the end here to fix CI 😉
```suggestion
exec "$@"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on code in PR #35235:
URL: https://github.com/apache/superset/pull/35235#discussion_r2369693476
##########
docker/docker-bootstrap.sh:
##########
@@ -18,9 +18,16 @@
set -eo pipefail
-# Make python interactive
+# Install critical dependencies first in dev mode to fix volume mount issues
if [ "$DEV_MODE" == "true" ]; then
if [ "$(whoami)" = "root" ] && command -v uv > /dev/null 2>&1; then
+ echo "Installing critical dependencies for dev mode..."
+ # Install pydantic first as it's needed for imports
+ uv pip install --no-cache-dir "pydantic>=2.8.0"
+ echo "Installing base requirements"
+ uv pip install -r /app/requirements/base.txt
+ echo "Reinstalling superset-core in editable mode"
+ uv pip install -e /app/superset-core
Review Comment:
@mistercrunch `superset-core` is similar to `superseet-ui-core`. I recommend reading [[SIP-177] Proposal for SQL Lab Extensions](https://github.com/apache/superset/issues/34162) to understand the structure better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: docker-compose file and superset-core [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #35235:
URL: https://github.com/apache/superset/pull/35235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org