You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bzz <gi...@git.apache.org> on 2016/09/07 06:31:16 UTC
[GitHub] zeppelin pull request #1410: Fix download links
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1410
Fix download links
### What is this PR for?
In recent changes download links were broken on the project website
### What type of PR is it?
Hot Fix
### Todos
* [x] - update Jekyll version
* [x] - update documentation, with `--safe` removed
* [x] - add "production" mode flag though `JEKYLL_ENV` aka plusjade/jekyll-bootstrap#84
### How should this be tested?
```
bundle update
JEKYLL_ENV=production bundle exec jekyll serve
```
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, it was
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bzz/incubator-zeppelin fix-download-links
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1410.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1410
----
commit 45bf884ff91685d2b038bc258b1e3c8c5a995c36
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-09-07T05:04:43Z
Backport of plusjade/jekyll-bootstrap#262 for website
commit f270a43d74f5d12da12024a900f9a7da76a227e6
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-09-07T05:41:03Z
Update Jekyll in order to use JEKYLL_ENV
commit 09f770eed3b517f7516b6f7cb3aa3bdd3dffb853
Author: Alexander Bezzubov <bz...@apache.org>
Date: 2016-09-07T05:54:04Z
Add missing dependency and update deprecated config
commit 68f4d640d6217e7331c5e7dfd01680314b166178
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-09-07T06:02:57Z
Backport https://github.com/plusjade/jekyll-bootstrap/pull/293
commit f774bb0a6e171e45ba5ff77d421b49dfb5dd96c6
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-09-07T06:17:01Z
Add extension to pages_list links
commit 2b04e4a979094707a6c47a12da9b215b1038f3cf
Author: Alexander <ab...@nflabs.com>
Date: 2016-09-07T06:27:14Z
Merge pull request #11 from corneadoug/fix/otherRenderingIssues
Backport https://github.com/plusjade/jekyll-bootstrap/pull/293 + add .html to `pages_list` links
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1410: Fix download links
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1410
@bzz Tested:
* Locally
* With Production Flag
* With SVN doc folder
LGTM, let's try to get it merged fast since it is a Hot Fix.
Documentation change for that PR is handled in #1405
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1410: Fix download links
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1410
Merging it in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1410: Fix download links
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1410
Yeah tested too and it works as expected. LGTM \U0001f44d
Let's merge this quickly as a Hotfix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1410: Fix download links
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1410
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---