You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Prasanna Santhanam <ts...@apache.org> on 2013/10/15 10:11:16 UTC
Re: Review Request 14229: CLOUDSTACK: 4256 - Fixed shared network test cases
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14229/#review27013
-----------------------------------------------------------
Ship it!
8350a6b - master
2c6b698 4.2
- Prasanna Santhanam
On Sept. 19, 2013, 12:17 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14229/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2013, 12:17 p.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Did following changes:
>
> 1) physical network was passed while creating network instead of vlan id. Corrected code to pass free vlan id.
> 2) Changed IP addresses (gateway, startip, endip) of second of the two networks so that the two vlan ranges don't overlap (even they should not be present in same subnet).
>
>
> Diffs
> -----
>
> test/integration/component/test_shared_networks.py 88bb018
>
> Diff: https://reviews.apache.org/r/14229/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gaurav Aradhye
>
>