You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2019/01/23 05:22:00 UTC

[jira] [Resolved] (BEAM-6447) Spotless paddedCell appears to cause unpredictable behavior

     [ https://issues.apache.org/jira/browse/BEAM-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kenneth Knowles resolved BEAM-6447.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Not applicable

> Spotless paddedCell appears to cause unpredictable behavior
> -----------------------------------------------------------
>
>                 Key: BEAM-6447
>                 URL: https://issues.apache.org/jira/browse/BEAM-6447
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>             Fix For: Not applicable
>
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7505 spotlessCheck passed even though spotlessApply was not a no-op.
> In https://github.com/apache/beam/pull/7523 and https://github.com/apache/beam/pull/7527 spotlessApply was run and the result _also_ passed spotlessCheck.
> Confirmed that spotlessCheck fails on https://github.com/apache/beam/pull/7505 if paddedCell is turned off. The use of paddedCell is to workaround bugs in the underlying formatter (in our case google-java-format). Currently, there is no known bug affecting us, so we should not be using paddedCell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)