[GitHub] [solr] patsonluk commented on pull request #1242: SOLR-16580: Avoid making copies of DocCollection for PRS updates

[GitBox <gi...@apache.org>]

patsonluk commented on PR #1242:
URL: https://github.com/apache/solr/pull/1242#issuecomment-1370091302

   > @hiteshk25 @patsonluk I have gotten rid of the `ThreadLocal` completely
   
   Nice! I see that DocCollection has a new ctor which makes things much easier to follow! I think having a different ctor is probably a right step, though it might be hard to convince the Solr community to adapt that as they don't see PRS as something to be enabled by default so far? If it stays that way, we might want to introduce a subclass that extends `DocCollection` which has PRS support? (to avoid modification to the existing "default" `DocCollection`) But that's a much more refactoring...
   
   I have also added https://github.com/cowpaths/fullstory-solr/commit/8a83fdfc20d4ae7dc832217ed8533aca3c0bb4ee to demonstrate the issue raised in https://github.com/apache/solr/pull/1242#discussion_r1054654494 . If we run that test on main branch it passes but on the current branch the replica within slice could miss the update.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org