You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/03/04 14:53:31 UTC
[GitHub] [tinkerpop] spmallette commented on issue #1250: fix for
https://issues.apache.org/jira/browse/TINKERPOP-2192
spmallette commented on issue #1250: fix for https://issues.apache.org/jira/browse/TINKERPOP-2192
URL: https://github.com/apache/tinkerpop/pull/1250#issuecomment-594573696
Since I see an initial vote on this one, I'll just add a few administrative points in relation to the review:
1. a CHANGELOG entry would be nice though whoever merges this could simply add that in
2. This change targets `master` - should it target an earlier branch? I'd guess it should at least target `3.4-dev` but perhaps it should even go back to `3.3-dev`? Thoughts @FlorianHockmann ?
3. Not sure why travis didn't like the last build - I've restarted the .NET body of tests.
4. Finally, @dzmitry-lahoda would you mind cleaning up the commit history a bit. It seems like this is a simple enough change that all of your commits on this PR could be squashed into one now that the review/feedback work is all done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services