You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/04/15 21:56:38 UTC
[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15739
Change subject: Revert "[catalog manager] cache masters' addresses"
......................................................................
Revert "[catalog manager] cache masters' addresses"
This reverts commit 069c00c3a490e83c26d076a9f3ac3a9c7a87631b.
Change-Id: I95a65435befc00d3b697ad83323eb08d999cabb5
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.cc
M src/kudu/master/master.h
M src/kudu/master/master_service.cc
5 files changed, 20 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/15739/1
--
To view, visit http://gerrit.cloudera.org:8080/15739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I95a65435befc00d3b697ad83323eb08d999cabb5
Gerrit-Change-Number: 15739
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15739 )
Change subject: Revert "[catalog manager] cache masters' addresses"
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I95a65435befc00d3b697ad83323eb08d999cabb5
Gerrit-Change-Number: 15739
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Apr 2020 22:53:56 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15739 )
Change subject: Revert "[catalog manager] cache masters' addresses"
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I95a65435befc00d3b697ad83323eb08d999cabb5
Gerrit-Change-Number: 15739
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 15 Apr 2020 22:12:25 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) Revert "[catalog manager] cache masters' addresses"
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15739 )
Change subject: Revert "[catalog manager] cache masters' addresses"
......................................................................
Revert "[catalog manager] cache masters' addresses"
This reverts commit 069c00c3a490e83c26d076a9f3ac3a9c7a87631b.
Change-Id: I95a65435befc00d3b697ad83323eb08d999cabb5
Reviewed-on: http://gerrit.cloudera.org:8080/15739
Reviewed-by: Hao Hao <ha...@cloudera.com>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/master/catalog_manager.cc
M src/kudu/master/catalog_manager.h
M src/kudu/master/master.cc
M src/kudu/master/master.h
M src/kudu/master/master_service.cc
5 files changed, 20 insertions(+), 24 deletions(-)
Approvals:
Hao Hao: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15739
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I95a65435befc00d3b697ad83323eb08d999cabb5
Gerrit-Change-Number: 15739
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)