You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/25 11:51:49 UTC
[GitHub] [arrow] xhochy opened a new pull request #9315: ARROW-11372: Support RC verification on macOS-ARM64
xhochy opened a new pull request #9315:
URL: https://github.com/apache/arrow/pull/9315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9315: ARROW-11372: Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9315:
URL: https://github.com/apache/arrow/pull/9315#issuecomment-766763089
https://issues.apache.org/jira/browse/ARROW-11372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on a change in pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
xhochy commented on a change in pull request #9315:
URL: https://github.com/apache/arrow/pull/9315#discussion_r563799499
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -215,7 +215,11 @@ setup_tempdir() {
setup_miniconda() {
# Setup short-lived miniconda for Python and integration tests
if [ "$(uname)" == "Darwin" ]; then
- MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
+ if [ "$(uname -m)" == "arm64" ]; then
+ MINICONDA_URL=https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh
+ else
+ MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
Review comment:
It doesn't really make a difference in the following steps, thus I would keep as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] cyb70289 commented on pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
cyb70289 commented on pull request #9315:
URL: https://github.com/apache/arrow/pull/9315#issuecomment-767305699
Looks this patch needs rebase?
I'd like to reference it to verify RC on Arm64 linux.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy closed pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
xhochy closed pull request #9315:
URL: https://github.com/apache/arrow/pull/9315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #9315:
URL: https://github.com/apache/arrow/pull/9315#discussion_r563787651
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -215,7 +215,11 @@ setup_tempdir() {
setup_miniconda() {
# Setup short-lived miniconda for Python and integration tests
if [ "$(uname)" == "Darwin" ]; then
- MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
+ if [ "$(uname -m)" == "arm64" ]; then
+ MINICONDA_URL=https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh
+ else
+ MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
Review comment:
Shouldn't we use miniforge in all cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on a change in pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
xhochy commented on a change in pull request #9315:
URL: https://github.com/apache/arrow/pull/9315#discussion_r563799499
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -215,7 +215,11 @@ setup_tempdir() {
setup_miniconda() {
# Setup short-lived miniconda for Python and integration tests
if [ "$(uname)" == "Darwin" ]; then
- MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
+ if [ "$(uname -m)" == "arm64" ]; then
+ MINICONDA_URL=https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh
+ else
+ MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
Review comment:
It doesn't really make a difference in the following steps, thus I would keep as-is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #9315: ARROW-11372: [Release] Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #9315:
URL: https://github.com/apache/arrow/pull/9315#discussion_r563787651
##########
File path: dev/release/verify-release-candidate.sh
##########
@@ -215,7 +215,11 @@ setup_tempdir() {
setup_miniconda() {
# Setup short-lived miniconda for Python and integration tests
if [ "$(uname)" == "Darwin" ]; then
- MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
+ if [ "$(uname -m)" == "arm64" ]; then
+ MINICONDA_URL=https://github.com/conda-forge/miniforge/releases/latest/download/Miniforge3-MacOSX-arm64.sh
+ else
+ MINICONDA_URL=https://repo.continuum.io/miniconda/Miniconda3-latest-MacOSX-x86_64.sh
Review comment:
Shouldn't we use miniforge in all cases?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9315: ARROW-11372: Support RC verification on macOS-ARM64
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9315:
URL: https://github.com/apache/arrow/pull/9315#issuecomment-766763089
https://issues.apache.org/jira/browse/ARROW-11372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org