You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/08/23 10:24:04 UTC

[GitHub] [incubator-mxnet] huww98 opened a new pull request #20549: [FEATURE] MXIndexedRecordIO: avoid re-build index

huww98 opened a new pull request #20549:
URL: https://github.com/apache/incubator-mxnet/pull/20549


   ## Description ##
   
   When resetting, avoid re-build index for read-only instances to save time and memory (in case of forked, memory pages can be shared)
   
   ## Checklist ##
   ### Essentials ###
   - [x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage
   - [ ] Code is well-documented
   
   ### Changes ###
   - [x] avoid reset index
   
   ## Comments ##
   
   This can save ~30G memory for us when running with 16 forked workers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] ptrendx merged pull request #20549: [FEATURE] MXIndexedRecordIO: avoid re-build index

Posted by GitBox <gi...@apache.org>.
ptrendx merged pull request #20549:
URL: https://github.com/apache/incubator-mxnet/pull/20549


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20549: [FEATURE] MXIndexedRecordIO: avoid re-build index

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20549:
URL: https://github.com/apache/incubator-mxnet/pull/20549#issuecomment-903640025


   Hey @huww98 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, sanity, website, edge, centos-cpu, windows-gpu, clang, centos-gpu, unix-cpu, unix-gpu, miscellaneous]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org