You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/07 11:27:55 UTC
[GitHub] [lucene] mayya-sharipova opened a new pull request #734: LUCENE-10408 Test correction checksum
mayya-sharipova opened a new pull request #734:
URL: https://github.com/apache/lucene/pull/734
Use double instead of float to test vector values checksum
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova merged pull request #734: LUCENE-10408 Test: correct type of checksum
Posted by GitBox <gi...@apache.org>.
mayya-sharipova merged pull request #734:
URL: https://github.com/apache/lucene/pull/734
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on pull request #734: LUCENE-10408 Test: correct type of checksum
Posted by GitBox <gi...@apache.org>.
mayya-sharipova commented on pull request #734:
URL: https://github.com/apache/lucene/pull/734#issuecomment-1060581581
As @jtibshirani reported, currently without this patch this test fails:
```txt
./gradlew test --tests TestPerFieldKnnVectorsFormat.testVectorValuesReportCorrectDocs -Dtests.seed=333F2D9CC8DA43F5 -Dtests.multiplier=2 -Dtests.nightly=true -Dtests.slow=true
```
with a message:
```
> java.lang.AssertionError: expected:<605.56494140625> but was:<605.5659790039062>
> at __randomizedtesting.SeedInfo.seed([333F2D9CC8DA43F5:B2FA0336857D5A3C]:0)
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotEquals(Assert.java:835)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani removed a comment on pull request #734: LUCENE-10408 Test: correct type of checksum
Posted by GitBox <gi...@apache.org>.
jtibshirani removed a comment on pull request #734:
URL: https://github.com/apache/lucene/pull/734#issuecomment-1061145754
I just noticed: we need a similar fix for `BaseKnnVectorsFormatTestCase#testSparseVectors`. I saw this test fail in CI because of a slight checksum mismatch (unfortunately the build link with a reproduce line has expired).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] jtibshirani commented on pull request #734: LUCENE-10408 Test: correct type of checksum
Posted by GitBox <gi...@apache.org>.
jtibshirani commented on pull request #734:
URL: https://github.com/apache/lucene/pull/734#issuecomment-1061145754
I just noticed: we need a similar fix for `BaseKnnVectorsFormatTestCase#testSparseVectors`. I saw this test fail in CI because of a slight checksum mismatch (unfortunately the build link with a reproduce line has expired).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org