[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1519: ifconfig: Support `ifconfig interface` and update arg limit

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #1519:
URL: https://github.com/apache/nuttx-apps/pull/1519#discussion_r1091992027


##########
nshlib/nsh_command.c:
##########
@@ -244,9 +244,10 @@ static const struct cmdmap_s g_cmdmap[] =
 
 #ifdef CONFIG_NET
 # ifndef CONFIG_NSH_DISABLE_IFCONFIG
-  { "ifconfig", cmd_ifconfig, 1, 11,
-    "[interface [<ip-address>|dhcp]] [dr|gw|gateway <dr-address>] "
-    "[netmask <net-mask>] [dns <dns-address>] [hw <hw-mac>]" },
+  { "ifconfig", cmd_ifconfig, 1, 12,

Review Comment:
   BTW, why 11 is changed to 12?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org