You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/08/19 21:53:45 UTC

Review Request 71314: Moved master-side agent draining tests into a separate file.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71314/
-----------------------------------------------------------

Review request for mesos, Benno Evers and Greg Mann.


Bugs: MESOS-9892
    https://issues.apache.org/jira/browse/MESOS-9892


Repository: mesos


Description
-------

The test bodies were not changed, besides renaming the test class.


Diffs
-----

  src/Makefile.am 0377c8dc4a0f876f972797556c98d88aaab86589 
  src/tests/CMakeLists.txt 04c552a828c6e262bcb66f552b4e42772e33623c 
  src/tests/api_tests.cpp e202cd330d424efef783d39b74db5f856bd34895 
  src/tests/master_draining_tests.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/71314/diff/1/


Testing
-------

make check


Thanks,

Joseph Wu


Re: Review Request 71314: Moved master-side agent draining tests into a separate file.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71314/#review217354
-----------------------------------------------------------


Ship it!




Ship It!

- Greg Mann


On Aug. 19, 2019, 9:53 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71314/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2019, 9:53 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Greg Mann.
> 
> 
> Bugs: MESOS-9892
>     https://issues.apache.org/jira/browse/MESOS-9892
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The test bodies were not changed, besides renaming the test class.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 0377c8dc4a0f876f972797556c98d88aaab86589 
>   src/tests/CMakeLists.txt 04c552a828c6e262bcb66f552b4e42772e33623c 
>   src/tests/api_tests.cpp e202cd330d424efef783d39b74db5f856bd34895 
>   src/tests/master_draining_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71314/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>