[jira] Commented: (SSHD-102) Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()

["Torsten Mielke (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971628#action_12971628 ] 

Torsten Mielke commented on SSHD-102:
-------------------------------------

I specifically added e.getCause() to the logging statement as in my case I was hitting an error:
java.lang.NumberFormatException: For input string: "10389""

when specifying an LDAP server uri escaped in double quotes. 
This real cause was only accessible when calling getCause() on the exception.


> Add error logging to org.apache.sshd.server.jaas.JaasPasswordAuthenticator.authenticate()
> -----------------------------------------------------------------------------------------
>
>                 Key: SSHD-102
>                 URL: https://issues.apache.org/jira/browse/SSHD-102
>             Project: MINA SSHD
>          Issue Type: Improvement
>    Affects Versions: 0.4.0, 0.5.0
>         Environment: sshd JAAS used with LDAP based authentication.
>            Reporter: Torsten Mielke
>         Attachments: JaasPasswordAuthenticator.patch
>
>
> The JaasPasswordAuthenticator.authenticate() method currently silently ignores any exceptions being raised and simply returns false in case of any authentication erorrs. 
> In environments where sshd is used in other frameworks like OSGi, it becomes very difficult to trouble shoot the reasons for the authentication failure. 
> Rather than simply returning false, I propose to print a logging statement at the least.
>     catch (Exception e) {
>             log.error("Authentication failed with " + 
>                       e.getMessage() + 
>                       ", cause: " + 
>                       e.getCause() );
>             return false;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.