You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@quickstep.apache.org by zuyu <gi...@git.apache.org> on 2017/01/06 21:29:26 UTC

[GitHub] incubator-quickstep pull request #155: Add min/max statistics and the exactn...

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/155#discussion_r95023137
  
    --- Diff: query_optimizer/ExecutionGenerator.cpp ---
    @@ -1232,8 +1242,11 @@ void ExecutionGenerator::convertInsertSelection(
           execution_plan_->addRelationalOperator(insert_selection_op);
       insert_destination_proto->set_relational_op_index(insert_selection_index);
     
    +  CatalogRelation *mutable_relation =
    +      catalog_database_->getRelationByIdMutable(selection_relation->getID());
    --- End diff --
    
    @jianqiao This is the root cause of my tests failures. We should change to `destination_relation` from `selection_relation`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---