You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2021/08/07 10:32:23 UTC
svn commit: r1892062 -
/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/TextJoinFunction.java
Author: fanningpj
Date: Sat Aug 7 10:32:22 2021
New Revision: 1892062
URL: http://svn.apache.org/viewvc?rev=1892062&view=rev
Log:
fix TextJoin use case that was not handled
Modified:
poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/TextJoinFunction.java
Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/TextJoinFunction.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/TextJoinFunction.java?rev=1892062&r1=1892061&r2=1892062&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/TextJoinFunction.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/atp/TextJoinFunction.java Sat Aug 7 10:32:22 2021
@@ -104,9 +104,9 @@ final class TextJoinFunction implements
if (eval instanceof AreaEval) {
AreaEval ae = (AreaEval)eval;
List<ValueEval> list = new ArrayList<>();
- for (int r = 0; r < ae.getHeight(); r++) {
- for (int c = 0; c < ae.getWidth(); c++) {
- list.add(ae.getRelativeValue(r, c));
+ for (int r = ae.getFirstRow(); r <= ae.getLastRow(); r++) {
+ for (int c = ae.getFirstColumn(); c <= ae.getLastColumn(); c++) {
+ list.add(OperandResolver.getSingleValue(ae.getAbsoluteValue(r, c), r, c));
}
}
return list;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org