DO NOT REPLY [Bug 12589] New: - jjtree doesn't log "Target is already built" correctly

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12589>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=12589

jjtree doesn't log "Target is already built" correctly

           Summary: jjtree doesn't log "Target is already built" correctly
           Product: Ant
           Version: 1.5
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Minor
          Priority: Other
         Component: Optional Tasks
        AssignedTo: ant-dev@jakarta.apache.org
        ReportedBy: kmundy@denovis.com


When the jjtree task reports that its target is already built, the message 
isn't prefixed with "   [jjtree] ", like it should be.
Also, this message is reported even when -verbose is not used, which is 
inconsistent with the javacc task.

To reproduce, put the following into build.xml and compare the outputs of "ant -
verbose" and "ant":
<project default="jjtree">
    <target name="jjtree">
        <delete><fileset dir="." includes="foo.jjt,foo.jj,foo.java"/></delete>
        <touch file="foo.jjt"/>
        <sleep seconds="2"/>
        <touch file="foo.jj"/>
        <jjtree target="foo.jjt" javacchome="."/>
        <sleep seconds="2"/>
        <touch file="foo.java"/>
        <javacc target="foo.jjt" javacchome="."/>
    </target>
</project>

I think the right fix is to change line 240 of 
src/main/org/apache/tools/ant/taskdefs/optional/javacc/JJTree.java from:
            project.log("Target is already built - skipping (" + target + ")");
to
            log("Target is already built - skipping (" + target + ")", 
Project.MSG_VERBOSE);

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>