You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Gopal V (JIRA)" <ji...@apache.org> on 2016/12/20 05:15:59 UTC

[jira] [Commented] (HIVE-15471) LLAP UI: NPE when getting thread metrics

    [ https://issues.apache.org/jira/browse/HIVE-15471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15763290#comment-15763290 ] 

Gopal V commented on HIVE-15471:
--------------------------------

LGTM - +1.

Quick q - did you mean to remove the loop?

{code}
         for (int j = 0; j < numExecutors; j++) {
{code}

I see a dead-code loop there?

> LLAP UI: NPE when getting thread metrics
> ----------------------------------------
>
>                 Key: HIVE-15471
>                 URL: https://issues.apache.org/jira/browse/HIVE-15471
>             Project: Hive
>          Issue Type: Bug
>          Components: llap
>            Reporter: Rajesh Balamohan
>            Assignee: Rajesh Balamohan
>            Priority: Minor
>         Attachments: HIVE-15471.1.patch
>
>
> When tasks are interrupted/killed in the middle of the job in LLAP, {{LlapDaemonExecutorMetrics.updateThreadMetrics}} could end up throwing NPE.
> {noformat}
> java.lang.NullPointerException
> 	at org.apache.hadoop.hive.llap.metrics.LlapDaemonExecutorMetrics.updateThreadMetrics(LlapDaemonExecutorMetrics.java:307) ~[hive-llap-server-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
> 	at org.apache.hadoop.hive.llap.metrics.LlapDaemonExecutorMetrics.getExecutorStats(LlapDaemonExecutorMetrics.java:269) ~[hive-llap-server-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
> 	at org.apache.hadoop.hive.llap.metrics.LlapDaemonExecutorMetrics.getMetrics(LlapDaemonExecutorMetrics.java:187) ~[hive-llap-server-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
> 	at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMetrics(MetricsSourceAdapter.java:194) ~[hadoop-common-2.7.1.jar:?]
> 	at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.updateJmxCache(MetricsSourceAdapter.java:172) ~[hadoop-common-2.7.1.jar:?]
> 	at org.apache.hadoop.metrics2.impl.MetricsSourceAdapter.getMBeanInfo(MetricsSourceAdapter.java:151) ~[hadoop-common-2.7.1.jar:?]
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.getMBeanInfo(DefaultMBeanServerInterceptor.java:1378) ~[?:1.8.0_77]
> 	at com.sun.jmx.mbeanserver.JmxMBeanServer.getMBeanInfo(JmxMBeanServer.java:920) ~[?:1.8.0_77]
> 	at org.apache.hive.http.JMXJsonServlet.listBeans(JMXJsonServlet.java:228) ~[hive-exec-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
> 	at org.apache.hive.http.JMXJsonServlet.doGet(JMXJsonServlet.java:194) ~[hive-exec-2.2.0-SNAPSHOT.jar:2.2.0-SNAPSHOT]
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)