[jira] [Commented] (HBASE-5245) HBase shell uses system JRuby if JRUBY_HOME is set, respects JRUBY_OPTS

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-5245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190563#comment-13190563 ] 

Hadoop QA commented on HBASE-5245:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12511411/hbase-jruby_home-and-jruby_opts.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/828//console

This message is automatically generated.
                
> HBase shell uses system JRuby if JRUBY_HOME is set, respects JRUBY_OPTS
> -----------------------------------------------------------------------
>
>                 Key: HBASE-5245
>                 URL: https://issues.apache.org/jira/browse/HBASE-5245
>             Project: HBase
>          Issue Type: Improvement
>          Components: shell
>    Affects Versions: 0.90.4
>            Reporter: Philip (flip) Kromer
>            Priority: Minor
>         Attachments: hbase-jruby_home-and-jruby_opts.patch
>
>
> Invoking {{hbase shell}}, the hbase runner launches the jruby jar directly, and so behaves differently than the traditional jruby runner. Specifically, it
> * does not respect the {{JRUBY_OPTS}} environment variable (among other things, I cannot launch the shell to use ruby-1.9 mode)
> * does not respect the {{JRUBY_HOME}} environment variable (placing things in an inconsistent state if my classpath holds the system jruby).
> This patch allows you to use an alternative jruby and to specify options to the jruby jar.
> * When the command is 'shell', adds {{$JRUBY_OPTS}} to the CLASS
> * When the command is 'shell' and {{$JRUBY_HOME}} is set, adds {{"$JRUBY_HOME/lib/jruby.jar"}} to the classpath, and sets {{-Djruby.home}} and {{-Djruby.job}} config variables.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira