You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by suvam97 <gi...@git.apache.org> on 2016/06/16 11:17:49 UTC
[GitHub] zeppelin pull request #1027: [ZEPPELIN-1020] Remove suggestion list on click
GitHub user suvam97 opened a pull request:
https://github.com/apache/zeppelin/pull/1027
[ZEPPELIN-1020] Remove suggestion list on click
### What is this PR for?
The suggestion list under note permissions for readers, writers & owners should hide on-click anywhere on the notebook.
### What type of PR is it?
[Bug Fix]
### Todos
### What is the Jira issue?
[ZEPPELIN-1020](https://issues.apache.org/jira/browse/ZEPPELIN-1020)
### How should this be tested?
1.Click on any field for setting permission for owners, readers & writers.
2.The suggestion list is displayed.
3.Now, click on any part of the notebook the suggestion list hides.
### Screenshots (if appropriate)
**BEFORE:**
http://g.recordit.co/7Esaq245Tp.gif
**AFTER**
http://g.recordit.co/Rfgn5dONPz.gif
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/suvam97/zeppelin ZEPPELIN-1020
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1027.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1027
----
commit a10928f4b3b9c02523b6c7db64640c2ad67a0861
Author: System Administrator <ro...@hw-c82a143827ce.local>
Date: 2016-06-16T10:45:27Z
remove suggestion list on click
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by ravicodder <gi...@git.apache.org>.
Github user ravicodder commented on the issue:
https://github.com/apache/zeppelin/pull/1027
@suvam97 Thanks for the contribution!! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1027
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1027
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1027
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1027
Merging this if no more discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by suvam97 <gi...@git.apache.org>.
Github user suvam97 commented on the issue:
https://github.com/apache/zeppelin/pull/1027
@prabhjyotsingh @r-kamath Thanks for the review!
@prabhjyotsingh done required changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by suvam97 <gi...@git.apache.org>.
Github user suvam97 commented on the issue:
https://github.com/apache/zeppelin/pull/1027
@corneadoug @ravicodder Thanks for reviewing ! Somehow missed to make changes .. Final changes updated ..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1027
I still see two line with '$'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1027: [ZEPPELIN-1020] Remove suggestion list on click
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/1027
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---