You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Lorenz Quack (JIRA)" <ji...@apache.org> on 2017/08/31 10:02:00 UTC
[jira] [Comment Edited] (QPID-7872) [Java Broker] [AMQP 1.0]
Message expiry should be driven from ttl header only
[ https://issues.apache.org/jira/browse/QPID-7872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16148760#comment-16148760 ]
Lorenz Quack edited comment on QPID-7872 at 8/31/17 10:01 AM:
--------------------------------------------------------------
If when adjusting the TTL the TTL falls to or below zero we set it to zero.
Unfortunately, other parts of the code consider a TTL of zero as "not set".
So, instead of expiring a message the change disables expiration. not good.
IMHO, a TTL of zero would mean it expired and should be deleted at the next opportune moment.
I would then consider a negative value or null to mean disabled/"not set". I have not checked whether that would conflict with any of the specs (unsigned int?) or (possibly broken) clients.
Also it seems that we are not adjusting the expiry/TTL on the other protocols.
was (Author: lorenz.quack):
If when adjusting the TTL the TTL falls to or below zero we set it to zero.
Unfortunately, other parts of the code consider a TTL of zero as "not set".
So, instead of expiring a message the change disables expiration. not good.
IMHO, a TTL of zero would mean it expired and should be deleted at the next opportune moment.
I would then consider a negative value or null to mean disabled/"not set". I have not checked whether that would conflict with any of the specs (unsigned int?) or (possibly broken) clients.
> [Java Broker] [AMQP 1.0] Message expiry should be driven from ttl header only
> -----------------------------------------------------------------------------
>
> Key: QPID-7872
> URL: https://issues.apache.org/jira/browse/QPID-7872
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Alex Rudyy
> Fix For: qpid-java-broker-7.0.0
>
>
> Java broker should only discard message with ttl header set if TTL expires including 0 values. Ensure TTL is adjusted before sending the message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org