You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/07/27 08:10:39 UTC
[GitHub] rhtyd commented on a change in pull request #1357: [4.9] CLOUDSTACK-8958: release dedicated ip range in domain removal
rhtyd commented on a change in pull request #1357: [4.9] CLOUDSTACK-8958: release dedicated ip range in domain removal
URL: https://github.com/apache/cloudstack/pull/1357#discussion_r129777825
##########
File path: server/src/com/cloud/user/DomainManagerImpl.java
##########
@@ -326,6 +329,14 @@ public boolean deleteDomain(DomainVO domain, Boolean cleanup) {
}
}
+ if (!_configMgr.releaseDomainSpecificVirtualRanges(domain.getId())) {
Review comment:
@ustcweizhou should this run only when cleanup is specified and is `true`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services